expression: fix convert number base for hybrid type #21554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lzmhhh123 <[email protected]>
Signed-off-by: lzmhhh123 <[email protected]>
|
/cc @ichn-hu |
|
/cc @XuHuaiyu |
lzmhhh123
added
needs-cherry-pick-4.0
sig/execution
Closed
ichn-hu
reviewed
Dec 8, 2020
Comment on lines
+1174
to
+1184
| if x.FuncName.L == ast.Cast { | ||
| arg0 := x.GetArgs()[0] | ||
| if arg0.GetType().Hybrid() || IsBinaryLiteral(arg0) { | ||
| str, isNull, err = arg0.EvalString(b.ctx, row) | ||
| if isNull || err != nil { | ||
| return str, isNull, err | ||
| } | ||
| d := types.NewStringDatum(str) | ||
| str = d.GetBinaryLiteral().ToBitLiteralString(true) | ||
| } | ||
| } |
There was a problem hiding this comment.
what if the func is not Cast but produces string that needs to be converted?
There was a problem hiding this comment.
When we build conv function. If the first argument is NOT string type. The cast would be wrapped. No other cases. You can refer to this code.
func (c *convFunctionClass) getFunction(ctx sessionctx.Context, args []Expression) (builtinFunc, error) {
if err := c.verifyArgs(args); err != nil {
return nil, err
}
bf, err := newBaseBuiltinFuncWithTp(ctx, c.funcName, args, types.ETString, types.ETString, types.ETInt, types.ETInt)
if err != nil {
return nil, err
}
bf.tp.Charset, bf.tp.Collate = ctx.GetSessionVars().GetCharsetInfo()
bf.tp.Flen = 64
sig := &builtinConvSig{bf}
sig.setPbCode(tipb.ScalarFuncSig_Conv)
return sig, nil
}
ichn-hu
reviewed
Dec 8, 2020
Comment on lines
+1073
to
+1074
| // TODO: change the vecEval match hybrid type fixing. Then open the vectorized evaluation. | ||
| return false |
There was a problem hiding this comment.
would you like to create an issue for this?
There was a problem hiding this comment.
I will update #12106, since the PR merged.
ti-srebot
approved these changes
Dec 9, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 9, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #21593 |
ti-srebot
added a commit
that referenced
this pull request
Jan 25, 2021
Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lzmhhh123 [email protected]<!-- Thank you for contributing to TiDB!
PR Title Format:
-->
What problem does this PR solve?
Issue Number: close #5817
What is changed and how it works?
How it Works: specified handle hybrid type for conv function.
Related changes
Check List
Tests
Side effects
Release note