Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinTrim3ArgsSig #13596

Merged
merged 4 commits into from
Nov 21, 2019
Merged

expression: implement vectorized evaluation for builtinTrim3ArgsSig #13596

merged 4 commits into from
Nov 21, 2019

Conversation

AerysNan
Copy link
Contributor

Signed-off-by: AerysNan [email protected]

PCP #12106

What problem does this PR solve?

Implement vectorized evaluation for builtinTrim3ArgsSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinStringFunc/builtinTrim3ArgsSig-VecBuiltinFunc-4                  29697             37926 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinTrim3ArgsSig-NonVecBuiltinFunc-4               17577             76310 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinTrim3ArgsSig-VecBuiltinFunc#01-4               26559             46683 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinTrim3ArgsSig-NonVecBuiltinFunc#01-4            12838             96674 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinTrim3ArgsSig-VecBuiltinFunc#02-4               25411             43928 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinTrim3ArgsSig-NonVecBuiltinFunc#02-4            14025             82855 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@AerysNan AerysNan requested a review from a team as a code owner November 19, 2019 15:14
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 19, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 19, 2019 15:14
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #13596 into master will increase coverage by 0.6947%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #13596        +/-   ##
================================================
+ Coverage   79.9094%   80.6041%   +0.6947%     
================================================
  Files           473        473                
  Lines        116159     117448      +1289     
================================================
+ Hits          92822      94668      +1846     
+ Misses        16012      15536       -476     
+ Partials       7325       7244        -81

wshwsh12
wshwsh12 reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2019
qw4990
qw4990 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

Your auto merge job has been accepted, waiting for 13601

@qw4990
Copy link
Contributor

qw4990 commented Nov 21, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Nov 21, 2019

/run-all-tests

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit ee8feeb into pingcap:master Nov 21, 2019
@AerysNan AerysNan deleted the vectorize/builtinTrim3ArgsSig branch November 21, 2019 08:04
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@AerysNan @XiaTianliang
expression: implement vectorized evaluation for builtinTrim3ArgsSig (…
98f6043 
…pingcap#13596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AerysNan @sre-bot @qw4990 @wshwsh12 @zz-jason