Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLocate2ArgsSig #12509

Merged
merged 13 commits into from
Oct 10, 2019
Merged

expression: implement vectorized evaluation for builtinLocate2ArgsSig #12509

merged 13 commits into from
Oct 10, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Oct 1, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinLocate2ArgsSig.
12106

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinStringFunc/builtinLocate2ArgsSig-VecBuiltinFunc-4     3457  355022 ns/op  16720 B/op  1615 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinLocate2ArgsSig-NonVecBuiltinFunc-4  3063  401838 ns/op  16720 B/op  1615 allocs/op

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 1, 2019
@codecov
Copy link

codecov bot commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #12509 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12509   +/-   ##
===========================================
  Coverage   79.8997%   79.8997%           
===========================================
  Files           460        460           
  Lines        103352     103352           
===========================================
  Hits          82578      82578           
  Misses        14721      14721           
  Partials       6053       6053

@zz-jason zz-jason requested review from qw4990 and fzhedu October 1, 2019 15:43
@qw4990 qw4990 requested a review from Reminiscent October 8, 2019 02:46
XuHuaiyu
XuHuaiyu reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzhedu fzhedu self-requested a review October 10, 2019 03:13
fzhedu
fzhedu approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

@b41sh merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Oct 10, 2019

/run-unit-test

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Oct 10, 2019

/run-unit-test

@ngaut ngaut removed the request for review from Reminiscent October 10, 2019 04:02
@ngaut ngaut merged commit e199319 into pingcap:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 left review comments

@SunRunAway SunRunAway SunRunAway left review comments

@fzhedu fzhedu fzhedu approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@b41sh @sre-bot @qw4990 @SunRunAway @ngaut @fzhedu @XuHuaiyu @zz-jason