Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement vectorized evaluation for builtinConvSig #14041

Merged
merged 6 commits into from
Dec 18, 2019
Merged

implement vectorized evaluation for builtinConvSig #14041

merged 6 commits into from
Dec 18, 2019

Conversation

ChiaoTeo
Copy link
Contributor

PCP #12106

What problem does this PR solve?

implement vectorized evaluation for builtinConvSig

What is changed and how it works?

BenchmarkVectorizedBuiltinMathFunc/builtinConvSig-VecBuiltinFunc-8                172767              6451 ns/op               0 B/op          0 allocs/op

BenchmarkVectorizedBuiltinMathFunc/builtinConvSig-NonVecBuiltinFunc-8              36088             33235 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@ChiaoTeo ChiaoTeo requested a review from a team as a code owner December 12, 2019 07:53
@sre-bot
Copy link
Contributor

sre-bot commented Dec 12, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team December 12, 2019 07:53
@codecov
Copy link

codecov bot commented Dec 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a887500). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #14041   +/-   ##
===========================================
  Coverage          ?   80.6571%           
===========================================
  Files             ?        483           
  Lines             ?     124325           
  Branches          ?          0           
===========================================
  Hits              ?     100277           
  Misses            ?      16121           
  Partials          ?       7927

@qw4990 qw4990 added component/expression contribution This PR is from a community contributor. labels Dec 12, 2019
wshwsh12
wshwsh12 reviewed Dec 13, 2019
View reviewed changes
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
@ChiaoTeo ChiaoTeo requested a review from wshwsh12 December 14, 2019 04:02
@ChiaoTeo ChiaoTeo requested a review from wshwsh12 December 17, 2019 11:33
wshwsh12
wshwsh12 reviewed Dec 18, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2019
@ChiaoTeo ChiaoTeo requested a review from qw4990 December 18, 2019 13:55
qw4990
qw4990 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Dec 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 964e893 into pingcap:master Dec 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

@zhaoqian888 complete task #12106 and get 50 score, currerent score 200.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ChiaoTeo @XiaTianliang
implement vectorized evaluation for builtinConvSig (pingcap#14041)
1601683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChiaoTeo @sre-bot @qw4990 @wshwsh12