Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinAesEncryptIVSig #13521

Merged
merged 4 commits into from
Nov 18, 2019
Merged

expression: implement vectorized evaluation for builtinAesEncryptIVSig #13521

merged 4 commits into from
Nov 18, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Nov 17, 2019

PCP #12106

What problem does this PR solve?

implement vectorized evaluation for builtinAesEncryptIVSig from #12106

What is changed and how it works?

about 20% faster

BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesEncryptIVSig-VecBuiltinFunc-12                   2811            377697 ns/op          406321 B/op       7131 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesEncryptIVSig-NonVecBuiltinFunc-12                2474            438656 ns/op          431201 B/op       8417 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesEncryptIVSig-VecBuiltinFunc#01-12                1674            656276 ns/op          737536 B/op       6620 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesEncryptIVSig-NonVecBuiltinFunc#01-12             1525            740945 ns/op          751472 B/op       7282 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesEncryptIVSig-VecBuiltinFunc#02-12                3282            347726 ns/op          396448 B/op       6420 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesEncryptIVSig-NonVecBuiltinFunc#02-12             2900            419048 ns/op          409776 B/op       7062 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner November 17, 2019 17:04
@sre-bot
Copy link
Contributor

sre-bot commented Nov 17, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 17, 2019 17:04
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 17, 2019
@codecov
Copy link

codecov bot commented Nov 17, 2019 •
edited
Loading

Codecov Report

Merging #13521 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13521   +/-   ##
===========================================
  Coverage   80.2856%   80.2856%           
===========================================
  Files           472        472           
  Lines        114906     114906           
===========================================
  Hits          92253      92253           
  Misses        15430      15430           
  Partials       7223       7223

qw4990
qw4990 reviewed Nov 18, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2019
Reminiscent
Reminiscent previously approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, WELL DONE!

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2019
@wshwsh12
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Your auto merge job has been accepted, waiting for 13314

@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 871c19b into pingcap:master Nov 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

@js00070 complete task #12106 and get 50 score, currerent score 450.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for `builtinAesEncryptIVS…
a6d8917 
…ig` (pingcap#13521)
@js00070 js00070 deleted the builtinAesEncryptIVSig branch February 1, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@Reminiscent Reminiscent Reminiscent left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@js00070 @sre-bot @wshwsh12 @qw4990 @Reminiscent