Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinCastDurationAsStringSig' #12541

Merged
merged 9 commits into from
Oct 9, 2019
Merged

expression: implement vectorized evaluation for 'builtinCastDurationAsStringSig' #12541

merged 9 commits into from
Oct 9, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 8, 2019 •
edited
Loading

What problem does this PR solve?

Implement vectorized evaluation for builtinCastDurationAsStringSig, for #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsStringSig-VecBuiltinFunc-8         	    5000	    352306 ns/op	  102205 B/op	    2917 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsStringSig-NonVecBuiltinFunc-8      	    5000	    367838 ns/op	  102206 B/op	    2917 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 8, 2019
@tsthght tsthght changed the title expression: implement vectorized evaluation for 'builtinCastDurationA… expression: implement vectorized evaluation for 'builtinCastDurationAsStringSig' Oct 8, 2019
Reminiscent
Reminiscent reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2019
Reminiscent
Reminiscent reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

@codecov
Copy link

codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a177d46). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12541   +/-   ##
===========================================
  Coverage          ?   79.8973%           
===========================================
  Files             ?        460           
  Lines             ?     103051           
  Branches          ?          0           
===========================================
  Hits              ?      82335           
  Misses            ?      14709           
  Partials          ?       6007

qw4990
qw4990 previously approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2019
@SunRunAway SunRunAway removed their request for review October 9, 2019 07:40
@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

@tsthght merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Oct 9, 2019

/build

@qw4990 qw4990 merged commit 8bd484b into pingcap:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsthght @sre-bot @qw4990 @XuHuaiyu @Reminiscent