Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinRightSig #12293

Merged
merged 3 commits into from
Sep 22, 2019
Merged

expression: implement vectorized evaluation for builtinRightSig #12293

merged 3 commits into from
Sep 22, 2019

Conversation

shihongzhi
Copy link
Member

@shihongzhi shihongzhi commented Sep 21, 2019 •
edited by qw4990
Loading

What problem does this PR solve?

implement vectorized evaluation for builtinRightSig , for #12106

What is changed and how it works?

$go test -v -benchmem -bench=BenchmarkVectorizedBuiltinStringFunc -run=BenchmarkVectorizedBuiltinStringFunc -args "builtinRightSig"
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinStringFunc/builtinRightSig-VecBuiltinFunc-4         	   17068	     71850 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinRightSig-NonVecBuiltinFunc-4      	   10000	    104396 ns/op	    9152 B/op	     664 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	3.024s

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 21, 2019
@codecov
Copy link

codecov bot commented Sep 21, 2019 •
edited
Loading

Codecov Report

Merging #12293 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #12293   +/-   ##
=========================================
  Coverage   81.107%   81.107%           
=========================================
  Files          454       454           
  Lines        98836     98836           
=========================================
  Hits         80163     80163           
  Misses       12894     12894           
  Partials      5779      5779

@shihongzhi shihongzhi marked this pull request as ready for review September 21, 2019 13:58
qw4990
qw4990 reviewed Sep 22, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SunRunAway
SunRunAway approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 22, 2019

Your auto merge job has been accepted, waiting for 12296

@sre-bot
Copy link
Contributor

sre-bot commented Sep 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit 9f0dfa2 into pingcap:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shihongzhi @sre-bot @SunRunAway @qw4990