Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinTimeFormatSig' #12478

Merged
merged 7 commits into from
Sep 30, 2019
Merged

expression: implement vectorized evaluation for 'builtinTimeFormatSig' #12478

merged 7 commits into from
Sep 30, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 29, 2019 •
edited by qw4990
Loading

What problem does this PR solve?

Implement vectorized evaluation for builtinTimeFormatSig, for #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinTimeFunc/builtinTimeFormatSig-VecBuiltinFunc-8         	   10000	    101142 ns/op   33347 B/op	    1224 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinTimeFormatSig-NonVecBuiltinFunc-8      	   10000	    123739 ns/op   33347 B/op	    1224 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 29, 2019
@codecov
Copy link

codecov bot commented Sep 29, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@01dce81). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master    #12478   +/-   ##
==========================================
  Coverage          ?   80.594%           
==========================================
  Files             ?       460           
  Lines             ?    106328           
  Branches          ?         0           
==========================================
  Hits              ?     85694           
  Misses            ?     14706           
  Partials          ?      5928

qw4990
qw4990 reviewed Sep 29, 2019
View reviewed changes
expression/bench_test.go Outdated Show resolved Hide resolved
@qw4990
Copy link
Contributor

qw4990 commented Sep 30, 2019

/run-all-tests

Reminiscent
Reminiscent reviewed Sep 30, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2019
@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

Your auto merge job has been accepted, waiting for 12413

@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

/run-all-tests

qw4990
qw4990 approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 merged commit 38f68bb into pingcap:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsthght @qw4990 @sre-bot @Reminiscent @zz-jason