Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCastDecimalAsDurationSig #13790

Merged
merged 6 commits into from
Nov 29, 2019
Merged

expression: implement vectorized evaluation for builtinCastDecimalAsDurationSig #13790

merged 6 commits into from
Nov 29, 2019

Conversation

dengsigua
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinCastDecimalAsDurationSig, for #12106

What is changed and how it works?

according to benchmark, about 5 times faster than before:

BenchmarkVectorizedBuiltinCastFunc/builtinCastDecimalAsDurationSig-VecBuiltinFunc-8               366718              3352 ns/op              0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDecimalAsDurationSig-NonVecBuiltinFunc-8             77730             15277 ns/op              0 B/op          0 allocs/op

Check List

Tests

  • Unit test\

@dengsigua dengsigua requested a review from a team as a code owner November 27, 2019 15:51
@ghost ghost requested review from qw4990 and wshwsh12 November 27, 2019 15:51
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 27, 2019
@ghost ghost removed their request for review November 27, 2019 15:51
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@francis0407
Copy link
Member

Please run go fmt in the expression package.

@codecov
Copy link

codecov bot commented Nov 28, 2019 •
edited
Loading

Codecov Report

Merging #13790 into master will decrease coverage by 0.5232%.
The diff coverage is 53.8461%.

@@               Coverage Diff                @@
##             master     #13790        +/-   ##
================================================
- Coverage   80.6352%   80.1119%   -0.5233%     
================================================
  Files           474        474                
  Lines        119769     116839      -2930     
================================================
- Hits          96576      93602      -2974     
- Misses        15783      15850        +67     
+ Partials       7410       7387        -23

@dengsigua
Copy link
Contributor Author

Please run go fmt in the expression package.

Please run go fmt in the expression package.

already modified, plz check
thanks~

@qw4990
Copy link
Contributor

qw4990 commented Nov 28, 2019

/run-all-tests

francis0407
francis0407 reviewed Nov 29, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6358a63 into pingcap:master Nov 29, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@dengsigua @XiaTianliang
expression: implement vectorized evaluation for `builtinCastDecimalAs…
8c067c5 
…DurationSig` (pingcap#13790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis0407 francis0407 francis0407 left review comments

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dengsigua @CLAassistant @francis0407 @qw4990 @sre-bot @wshwsh12