Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really use max_operations_propagation_time #3202

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Really use max_operations_propagation_time #3202

merged 1 commit into from
Nov 3, 2022

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Nov 3, 2022 •
edited by AurelienFT
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds mentioned this pull request Nov 3, 2022
Closed
@sydhds sydhds requested a review from damip November 3, 2022 08:50
damip
damip approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@sydhds sydhds merged commit e4b19f5 into testnet_17 Nov 3, 2022
@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
@AurelienFT AurelienFT deleted the fix/use_max_operations_propagation_time branch May 29, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @damip