Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byte array update #3221

Merged
merged 15 commits into from
Nov 23, 2022
Merged

Byte array update #3221

merged 15 commits into from
Nov 23, 2022

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Nov 19, 2022 •
edited
Loading

  • try in sandbox / simulation / labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass

@Eitu33 Eitu33 changed the base branch from main to testnet_17 November 19, 2022 22:00
@Eitu33 Eitu33 mentioned this pull request Nov 19, 2022
Closed
@sydhds sydhds self-requested a review November 22, 2022 09:04
sydhds
sydhds requested changes Nov 22, 2022
View reviewed changes
tools/setup_test.rs Show resolved Hide resolved
tools/setup_test.rs Outdated Show resolved Hide resolved
massa-execution-worker/Cargo.toml Outdated Show resolved Hide resolved
massa-execution-worker/src/tests/scenarios_mandatories.rs Show resolved Hide resolved
massa-execution-worker/src/tests/scenarios_mandatories.rs Outdated Show resolved Hide resolved
massa-execution-worker/src/tests/scenarios_mandatories.rs Show resolved Hide resolved
massa-execution-worker/src/tests/scenarios_mandatories.rs Show resolved Hide resolved
AurelienFT
AurelienFT reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to say than the review above.

@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
@Eitu33 Eitu33 mentioned this pull request Nov 23, 2022
Closed
sydhds
sydhds reviewed Nov 23, 2022
View reviewed changes
tools/setup_test.rs Outdated Show resolved Hide resolved
@Eitu33 Eitu33 merged commit fffb4ee into testnet_17 Nov 23, 2022
@sydhds sydhds deleted the byte-array-update branch November 23, 2022 14:27
@AurelienFT AurelienFT mentioned this pull request Nov 23, 2022
Closed
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT left review comments

@sydhds sydhds sydhds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eitu33 @sydhds @AurelienFT