Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade versions #3232

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Upgrade versions #3232

merged 3 commits into from
Nov 23, 2022

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Nov 22, 2022 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Need to fix compilation

damip
damip reviewed Nov 22, 2022
View reviewed changes
massa-signature/Cargo.toml Outdated Show resolved Hide resolved
@AurelienFT
Copy link
Contributor Author

Rand can't be update for now but should be able soon as the update has been done on ed25519_dalek but in a RC version. dalek-cryptography/ed25519-dalek#162 (comment)

@AurelienFT AurelienFT marked this pull request as ready for review November 22, 2022 23:03
@AurelienFT AurelienFT mentioned this pull request Nov 23, 2022
Merged
@AurelienFT AurelienFT requested a review from Eitu33 November 23, 2022 08:31
Eitu33
Eitu33 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@Eitu33 Eitu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astonishing

@AurelienFT AurelienFT merged commit 02b0bde into testnet_17 Nov 23, 2022
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
@AurelienFT AurelienFT deleted the upgrade_versions branch May 29, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip left review comments

@Eitu33 Eitu33 Eitu33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @damip @Eitu33