Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final state hash #3210

Merged
merged 28 commits into from
Nov 28, 2022
Merged

Final state hash #3210

merged 28 commits into from
Nov 28, 2022

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Nov 9, 2022 •
edited
Loading

Context

This PR covers:

  1. Async pool hash
  2. PoS deferred credits hash
  3. PoS cycle history hash
  4. Final state global hash

The rest of final state hash computations have already been implemented

TODOS

  • document all added functions
  • try in sandbox / simulation / labnet
  • unit tests on the added / changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems

@Eitu33 Eitu33 changed the base branch from testnet_17 to fix-deferred-credits November 21, 2022 16:54
@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
@Eitu33 Eitu33 changed the base branch from fix-deferred-credits to testnet_17 November 23, 2022 18:08
@Eitu33 Eitu33 requested a review from AurelienFT November 24, 2022 16:03
AurelienFT
AurelienFT reviewed Nov 25, 2022
View reviewed changes
massa-async-pool/src/pool.rs Outdated Show resolved Hide resolved
massa-async-pool/src/pool.rs Show resolved Hide resolved
massa-async-pool/src/pool.rs Show resolved Hide resolved
massa-final-state/src/final_state.rs Outdated Show resolved Hide resolved
massa-pos-exports/src/cycle_info.rs Outdated Show resolved Hide resolved
massa-pos-exports/src/deferred_credits.rs Show resolved Hide resolved
@AurelienFT
Copy link
Contributor

@Eitu33 As a general it would be nice to have a comment on the function is they are speculative or final so that we know it on the future and so need to change the hash or not

@Eitu33
Copy link
Contributor Author

Eitu33 commented Nov 25, 2022

Only apply_changes functions are usually final-only so I don't believe it is that hard to track, but I agree that it could be more explicit

@Eitu33 Eitu33 merged commit 5047393 into testnet_17 Nov 28, 2022
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
@Eitu33 Eitu33 mentioned this pull request Dec 9, 2022
Closed
6 tasks
@AurelienFT AurelienFT deleted the final-state-hash branch May 29, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eitu33 @AurelienFT