Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework consensus and graph #3162

Merged
merged 47 commits into from
Nov 16, 2022
Merged

Rework consensus and graph #3162

merged 47 commits into from
Nov 16, 2022

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Oct 18, 2022 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT
Init v2 exports massa-graph.
81fca31
@AurelienFT
Add skeleton of new graph.
d4cd93f
@AurelienFT
Add main loop of graph worker.
14fac1c
@AurelienFT
Fix main loop graph to avoid skipping slot when receiving command fro…
171349e 
…m protocol.
@AurelienFT
Add shared state in graph thread and graph controller.
c5a64fc
@AurelienFT
Add first version of init of new block graph.
6d33ce6
@AurelienFT
Refactor init function.
f6eb377
@AurelienFT
Add getter function and fill the state.
b72fe50
@AurelienFT
Add commands manager.
3b4c990
@AurelienFT
Add lock for state.
4da3972
@AurelienFT
Move all variable in the state and the functions that process it.
d69a802
@AurelienFT
Merge branch 'main' into remove_consensus
036696c
@AurelienFT
Merge branch 'main' into remove_consensus
384928e
@AurelienFT
Add slot tick to new version of consensus. Need to fix errors with pr…
c9cdba1 
…otocol sender.
@AurelienFT
Merge branch 'main' into remove_consensus
42c0b6c
@AurelienFT
Fix send protocol.
86dd52d
@AurelienFT
Add process of block and block header
91e1ea8
@AurelienFT
Add fetch get stats.
10c5130
@AurelienFT
Move code from worker to state.
54db8d3
@AurelienFT
Move graph functions in a specific file.
bbd8d43
@AurelienFT
Add docs and split functions of the graph.
a41f567
@AurelienFT
Format and clippy.
1aea183
@AurelienFT
Add documentation about state and channels communication in graph
5e0c96f
@AurelienFT
Link new graph to the main.
387d5ef
@AurelienFT AurelienFT changed the title Link new graph to the main. Link new graph to the rest of the project. Oct 18, 2022
@AurelienFT AurelienFT changed the base branch from main to prepare_testnet_16 October 24, 2022 14:25
@AurelienFT AurelienFT mentioned this pull request Oct 24, 2022
Closed
@AurelienFT AurelienFT marked this pull request as ready for review October 24, 2022 23:02
@AurelienFT AurelienFT requested a review from damip October 24, 2022 23:02
@AurelienFT
Copy link
Contributor Author

Still few points to address tomorrow on formatting, verifications, etc but the PR works.

@AurelienFT AurelienFT changed the title Link new graph to the rest of the project. Rework consensus and graph Oct 24, 2022
@AurelienFT AurelienFT changed the base branch from prepare_testnet_16 to testnet_17 October 25, 2022 07:09
@AurelienFT
Copy link
Contributor Author

Labnet node stopped without errors after few cycles :

2022-10-25T11:14:12.527472Z DEBUG massa_execution_worker::execution: execute_candidate_slot: executing slot=(period: 757, thread: 3) target=None
2022-10-25T11:14:12.581657Z DEBUG massa_factory_worker::endorsement_factory: endorsement LoYPQF7TwtTBqauexHwycqKzhQR9jXa99EEhiKwVvQtoFyirZ created at slot (period: 757, thread: 18) by address A1qS7hYYYvSc61KMPWVi124k44hZAJSXKPvboYg1m2YiSDveWAp
2022-10-25T11:14:12.605213Z  INFO massa_factory_worker::block_factory: block oN29zrGTakxGe3gHxMAW655WjzZ3B65dZUvkR7FTVnEaHpExG created at slot (period: 757, thread: 7) by address A1qS7hYYYvSc61KMPWVi124k44hZAJSXKPvboYg1m2YiSDveWAp
2022-10-25T11:14:12.694980Z DEBUG massa_execution_worker::execution: execute_candidate_slot: execution finished
2022-10-25T11:14:12.728827Z DEBUG massa_graph_2_worker::state::process_commands: received block oN29zrGTakxGe3gHxMAW655WjzZ3B65dZUvkR7FTVnEaHpExG for slot (period: 757, thread: 7)
2022-10-25T11:14:12.777622Z DEBUG massa_execution_worker::execution: execute_candidate_slot: execution state applied
2022-10-25T11:14:12.803979Z DEBUG massa_factory_worker::endorsement_factory: endorsement 28UeLnt2Bao8hHzgL1mwShXjwWtH5x1wwXKagpqsVKYvjMiBvB created at slot (period: 757, thread: 18) by address A1qS7hYYYvSc61KMPWVi124k44hZAJSXKPvboYg1m2YiSDveWAp
2022-10-25T11:14:12.879222Z DEBUG massa_execution_worker::worker: Execution loop triggered, input_data = stop=false, finalized={}, blockclique=None, readonly=RequestQueue { max_items: 10000, queue: [] }
2022-10-25T11:14:12.983455Z DEBUG massa_factory_worker::endorsement_factory: endorsement 2TZSHHUPDHtpQi2jgYbro912uVw7EALfhwxg7BVZUAsmJ1eHf2 created at slot (period: 757, thread: 18) by address A1qS7hYYYvSc61KMPWVi124k44hZAJSXKPvboYg1m2YiSDveWAp
2022-10-25T11:14:13.304980Z DEBUG massa_execution_worker::execution: execute_candidate_slot: executing slot=(period: 757, thread: 4) target=None
2022-10-25T11:14:13.519162Z DEBUG massa_execution_worker::execution: execute_candidate_slot: execution finished

Eitu33
Eitu33 reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@Eitu33 Eitu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I do not consider myself qualified to approve this PR

@AurelienFT
Copy link
Contributor Author

PR has been tested on labnet.

@AurelienFT AurelienFT merged commit 588e210 into testnet_17 Nov 16, 2022
@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
@AurelienFT AurelienFT mentioned this pull request Dec 1, 2022
Closed
@AurelienFT AurelienFT deleted the link_new_graph branch May 29, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 left review comments

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @damip @Eitu33