Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus bootstrap streaming #3192

Merged
merged 44 commits into from
Nov 16, 2022
Merged

Consensus bootstrap streaming #3192

merged 44 commits into from
Nov 16, 2022

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Oct 28, 2022 •
edited
Loading

  • document all added functions
  • try in simulation & labnet
  • unit tests on the added & changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems

@Eitu33 Eitu33 changed the base branch from main to link_new_graph October 28, 2022 13:24
@Eitu33 Eitu33 marked this pull request as draft October 28, 2022 13:24
Eitu33 added 27 commits October 28, 2022 16:41
@Eitu33
Start updating the manage_bootstrap function.
f69da2c
@Eitu33
Update state and consensus end cond.
381a00a
@Eitu33
Start updating messages.
9edbb8e
@Eitu33
Rename all messages accordingly.
f388005
@Eitu33
Update bootstrap messages.
1983038
@Eitu33
Update consensus mock.
c9a114e
@Eitu33
Merge source branch and fix conflicts.
8d3c862
@Eitu33
Updat bootstrap test.
c921b02
@Eitu33
Fix never-ending streaming issue.
f62133b
@Eitu33
Update consensus' get_bootstrap_part finished behaviour.
b3adf32
@Eitu33
Fix bootstrap client consensus part handling issue & update test_boot…
eacbcad 
…strap_server.
@Eitu33
Debug logs.
b68d2a9
@Eitu33
Fix logs compilation.
44ea6ac
@Eitu33
get_bootstrap_part debug updates.
d0f4bf7
@Eitu33
Fix debug compilation
2343b34
@Eitu33
Fix part of get_bootstrap_part behaviour.
b180402
@Eitu33
Temporary one batch consensus bootstrap for global behaviour testing.
1d35f42
@Eitu33
Update list_required_active_blocks return value and re-enable consens…
0092bde 
…us bootstrap expected behaviour.
@Eitu33
Disable matching slot finish condition.
006de38
@Eitu33
Consensus streaming cursor udpate, according bootstrap messages updat…
8c2da1b 
…e, generic vector ser & deser, block id ser & deser
@Eitu33
Update consensus bootstrap cursor and prehashset ser & deser
8164532
@Eitu33
Refactor consensus get_bootstrap_part
149b943
@Eitu33
Update consensus get_bootstrap_part behaviour
b7de571
@Eitu33
Update consensus get_bootstrap_part documentation
1d6d1c9
@Eitu33
Slight get_bootstrap_part behaviour change + debug logs
f23d68c
@Eitu33
Update mock and bootstrap test
0b52838
@Eitu33
Remove the full operations from ExportActiveBlock graph
2347fa4
@Eitu33 Eitu33 marked this pull request as ready for review November 8, 2022 17:00
@Eitu33 Eitu33 requested a review from AurelienFT November 8, 2022 17:00
AurelienFT
AurelienFT reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good PR. Real claps Thomas

massa-bootstrap/src/client.rs Show resolved Hide resolved
massa-consensus-worker/src/controller.rs Outdated Show resolved Hide resolved
massa-consensus-worker/src/controller.rs Outdated Show resolved Hide resolved
massa-consensus-worker/src/state/prune.rs Outdated Show resolved Hide resolved
@Eitu33 Eitu33 changed the base branch from link_new_graph to testnet_17 November 16, 2022 10:07
@Eitu33
Copy link
Contributor Author

Eitu33 commented Nov 16, 2022

Last possible issues have been investigated and validated by @damip :

  • Block operations request after a recent consensus bootstrap (Not an issue)
  • API behaviour on blocks without operations (Not an issue)
  • Pruning of the consensus bootstrap cursor (Done)
  • Init of the execution controller without complete operations after consensus bootstrap (Not an issue)

@Eitu33
Copy link
Contributor Author

Eitu33 commented Nov 16, 2022

Merging

@Eitu33 Eitu33 merged commit e560808 into testnet_17 Nov 16, 2022
@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
@AurelienFT AurelienFT deleted the consensus-blocks-streaming branch May 29, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eitu33 @AurelienFT