Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all the required types from str to byte array #39

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Change all the required types from str to byte array #39

merged 6 commits into from
Nov 25, 2022

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Nov 16, 2022 •
edited
Loading

⚠️ DO NOT merge this until corresponding updates have been done on the other repositories

@Eitu33 Eitu33 mentioned this pull request Nov 19, 2022
Closed
sydhds
sydhds reviewed Nov 22, 2022
View reviewed changes
assembly/std/index.ts Outdated Show resolved Hide resolved
@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
@AurelienFT
Copy link
Contributor

@ASAPSegfault and @peterjah I have put you as a review because you are aware of the situation but if you want feel free to switch it to someone else.

@AurelienFT AurelienFT merged commit fcc925d into main Nov 25, 2022
@Thykof Thykof mentioned this pull request Nov 25, 2022
Closed
bors bot added a commit to massalabs/massa that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
@Thykof Thykof deleted the byte-array-update branch December 8, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT left review comments

@sydhds sydhds sydhds left review comments

@peterjah peterjah peterjah approved these changes

@ASAPSegfault ASAPSegfault Awaiting requested review from ASAPSegfault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eitu33 @AurelienFT @sydhds @peterjah