Feature/deferred credits abs fixes #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sydhds
commented
Nov 3, 2022
•
sydhds
commented
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
added 8 commits
November 2, 2022 15:42
|
While reviewing & talking about deferred credits, some issues were spotted:
Roll sell unit test has also been modified in order to exercise the deferred credits absolute value store + check that deferred credits are reimbursed. |
damip
reviewed
Nov 4, 2022
damip
reviewed
Nov 4, 2022
|
ActiveHistory::fetch_deferred_credits_after needs to be deleted |
Done |
damip
reviewed
Nov 10, 2022
damip
reviewed
Nov 10, 2022
damip
reviewed
Nov 10, 2022
|
LGTM, let's do the checklist :) @sydhds |
Merged
bors bot
added a commit
that referenced
this pull request
Nov 30, 2022
3181: Testnet 17 r=AurelienFT a=gterzian This PR is a batch for testnet 17. These PRs should be merged before merging this one : - #3202 - #3205 - #3162 - #3203 - #3232 - #3192 - #3229 - #3221 - #3219 - #3210 - #3191 - #3173 - massalabs/massa-sc-runtime#161 - massalabs/massa-sc-runtime#164 - #3253 - #3249 - #3238 After merging this PR we should merge these before release testnet 17 : - massalabs/massa-as-sdk#49 - massalabs/massa-as-sdk#39 Co-authored-by: AurelienFT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.