Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lib config 0.11 to 0.13 #3205

Merged
merged 1 commit into from
Nov 4, 2022
Merged

update lib config 0.11 to 0.13 #3205

merged 1 commit into from
Nov 4, 2022

Conversation

modship
Copy link
Member

@modship modship commented Nov 4, 2022 •
edited by AurelienFT
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship mentioned this pull request Nov 4, 2022
Closed
@AurelienFT AurelienFT self-requested a review November 4, 2022 10:40
AurelienFT
AurelienFT approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Very good PR. ❤️

@AurelienFT AurelienFT merged commit e698625 into massalabs:testnet_17 Nov 4, 2022
@AurelienFT
Copy link
Contributor

Tested in sandbox and bootstrap with a second node.

@AurelienFT AurelienFT mentioned this pull request Nov 22, 2022
Merged
bors bot added a commit that referenced this pull request Nov 30, 2022
@bors @AurelienFT
Merge #3181
5044f28 
3181: Testnet 17 r=AurelienFT a=gterzian

This PR is a batch for testnet 17. These PRs should be merged before merging this one : 

- #3202 
- #3205
- #3162
- #3203
- #3232
- #3192
- #3229 
- #3221 
- #3219 
- #3210 
- #3191 
- #3173 
- massalabs/massa-sc-runtime#161
- massalabs/massa-sc-runtime#164
- #3253 
- #3249 
- #3238 

After merging this PR we should merge these before release testnet 17 : 
- massalabs/massa-as-sdk#49
- massalabs/massa-as-sdk#39

Co-authored-by: AurelienFT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modship @AurelienFT