All non-malformed operations and endorsements propagate

[damip]

Currently, all operations and endorsements that properly deserialize will propagate to the whole network.
This presents a high risk of flooding and some checks need to be performed before propagating them.

TOOD: define which checks:

• for ops:
  • validity period
  • available balance to pay the fees (also taking pool into account ?) ?
• for endorsements:
  • check pos draws
  • make sure we know the targeted block and that it is not stale
  • ignore multiple endorsements per (slot, index) per address

[sydhds]

From what I read in the code, there is already some filtering for operations:

massa/massa-protocol-worker/src/protocol_worker.rs

Line 964 in d09e9b6

// Propagate operations when their expire period isn't `max_operations_propagation_time` old.

and for endorsements:

massa/massa-protocol-worker/src/protocol_worker.rs

Line 1065 in d09e9b6

// Propagate endorsements when the slot of the block they endorse isn't `max_endorsements_propagation_time` old.

I've added a quick fix here:

#3202

[sydhds]

@damip can we discuss about what we should do next for this issue?

[damip]

Oh ok, then it should be OK for now ! we can merge the correction

[sydhds]

@damip Should we close the issue or keep it like that for now?

[AurelienFT]

From the list above only : for endorsements: check pos draws is done in protocol