Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geant4 to 10.7ref09 #7436

Merged
merged 8 commits into from
Jan 25, 2022

Conversation

ddaina
Copy link
Contributor

@ddaina ddaina commented Nov 9, 2021

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

A new Pull Request was created by @ddaina (Daina) for branch IB/CMSSW_12_2_X/geant4_vecgeom.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 9, 2021

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/20359/summary.html
COMMIT: 48caf67
CMSSW: CMSSW_12_2_G4VECGEOM_X_2021-11-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7436/20359/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/g++ -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/lib/CLHEP-2.4.5.1/../../include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/geant4/10.7ref09-d8b4ec65cd6f348dfcf9b68e480ebed7/include/Geant4 -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/include -isystem /cvmfs/cms-ib.cern.ch/nweek-02706/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/expat/2.1.0-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/zlib/1.2.11-bcolbf/include -fPIC -pthread -ftls-model=global-dynamic -std=c++17  -O3 -DNDEBUG -fno-trapping-math -ftree-vectorize -fno-math-errno -O3 -DNDEBUG -pthread -std=gnu++17 -o CMakeFiles/ParFullCMS.dir/src/MyPrimaryGeneratorAction.cc.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/src/MyPrimaryGeneratorAction.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/g++ -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/lib/CLHEP-2.4.5.1/../../include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/geant4/10.7ref09-d8b4ec65cd6f348dfcf9b68e480ebed7/include/Geant4 -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/include -isystem /cvmfs/cms-ib.cern.ch/nweek-02706/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/expat/2.1.0-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/zlib/1.2.11-bcolbf/include -fPIC -pthread -ftls-model=global-dynamic -std=c++17  -O3 -DNDEBUG -fno-trapping-math -ftree-vectorize -fno-math-errno -O3 -DNDEBUG -pthread -std=gnu++17 -o CMakeFiles/ParFullCMS.dir/src/MyRunAction.cc.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/src/MyRunAction.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/g++ -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/lib/CLHEP-2.4.5.1/../../include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/geant4/10.7ref09-d8b4ec65cd6f348dfcf9b68e480ebed7/include/Geant4 -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/include -isystem /cvmfs/cms-ib.cern.ch/nweek-02706/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/expat/2.1.0-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/zlib/1.2.11-bcolbf/include -fPIC -pthread -ftls-model=global-dynamic -std=c++17  -O3 -DNDEBUG -fno-trapping-math -ftree-vectorize -fno-math-errno -O3 -DNDEBUG -pthread -std=gnu++17 -o CMakeFiles/ParFullCMS.dir/src/MySteppingAction.cc.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/src/MySteppingAction.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/g++ -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/lib/CLHEP-2.4.5.1/../../include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/geant4/10.7ref09-d8b4ec65cd6f348dfcf9b68e480ebed7/include/Geant4 -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/include -isystem /cvmfs/cms-ib.cern.ch/nweek-02706/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/expat/2.1.0-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/zlib/1.2.11-bcolbf/include -fPIC -pthread -ftls-model=global-dynamic -std=c++17  -O3 -DNDEBUG -fno-trapping-math -ftree-vectorize -fno-math-errno -O3 -DNDEBUG -pthread -std=gnu++17 -o CMakeFiles/ParFullCMS.dir/src/MyUserActionInitialization.cc.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/src/MyUserActionInitialization.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/src/MyDetectorConstruction.cc: In member function 'virtual G4VPhysicalVolume* MyDetectorConstruction::Construct()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/src/MyDetectorConstruction.cc:89:66: error: 'Invisible' is not a member of 'G4VisAttributes'
89 |   fWorld->GetLogicalVolume()->SetVisAttributes (G4VisAttributes::Invisible);
|                                                                  ^~~~~~~~~
make[2]: *** [CMakeFiles/ParFullCMS.dir/src/MyDetectorConstruction.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/geant4-parfullcms/2014.01.27-0a10cec1251999c043cf01d25bc4f992/ParFullCMS/build-ParFullCMS'


@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 9, 2021

@civanch , looks like geant4-parfullcms does not work with new geant4 version. Any reason to keep building geant4-parfullcms , can we drop it from cmssw distro? Note that geant4-parfullcms is not maintained any more , the source code of this are downloaded from http://davidlt.web.cern.ch/davidlt/vault/%{realname}.%{realversion}.tar.bz2 ( and the person davidlt has left cms a long time ago)

@civanch
Copy link
Contributor

civanch commented Nov 9, 2021

@smuzaffar , there is no reason to build parfullsim - I am not sure it was ever used recent years.

@smuzaffar
Copy link
Contributor

@ddaina , can you please update this PR and remove geant4-parfullcms

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

Pull request #7436 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/20363/summary.html
COMMIT: 3f38eb5
CMSSW: CMSSW_12_2_G4VECGEOM_X_2021-11-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7436/20363/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/build-g4/DDG4 && /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/c++ -DBOOST_SPIRIT_USE_PHOENIX_V3 -DDD4HEP_USE_GEANT4_UNITS=1 -DDD4HEP_USE_XERCESC -DG4LIB_BUILD_DLL -DG4UI_USE_TCSH -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/dd4hep-v01-18x/DDG4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/dd4hep-v01-18x/DDCore/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/dd4hep-v01-18x/DDParsers/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/lcg/root/6.22.08-8d9ab2b279c3f35e6100d909611c3c2f/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-54c7e1bcbc2926e805a58d14bfba639b/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/geant4/10.7ref09-d8b4ec65cd6f348dfcf9b68e480ebed7/include/Geant4 -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/clhep/2.4.5.1-0f520ff8878ead52d387082ff8c4c011/include -isystem /cvmfs/cms-ib.cern.ch/nweek-02706/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/vecgeom/v1.1.17-aab934c97bdc17b3ce1e7d9fb1ac5cbe/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/expat/2.1.0-bcolbf2/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/zlib/1.2.11-bcolbf/include -ftls-model=global-dynamic -pedantic -Wextra -Wall -fdiagnostics-color=auto -Wdeprecated -Wno-long-long -Wformat-security -Wshadow           -pthread -O3 -DNDEBUG -fPIC -pthread -ftls-model=global-dynamic -std=c++17 -std=c++17 -o CMakeFiles/DDG4.dir/src/Geant4Primary.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/dd4hep-v01-18x/DDG4/src/Geant4Primary.cpp
make[2]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/build-g4'
make[1]: *** [DDG4/CMakeFiles/DDG4.dir/all] Error 2
make[1]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/build-g4'
make: *** [all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0ohtOx (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0ohtOx (%build)



@smuzaffar
Copy link
Contributor

@civanch , right so dd4hep failed to build with newer geant4 ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/20363/external/dd4hep/v01-18x-b0ba8d9db156bba37a2d9b5cfd320054/log ) . should we open issue with dd4hep ( I am not sure if they have access to geant4 11 code to test)?

@civanch
Copy link
Contributor

civanch commented Nov 9, 2021

@smuzaffar , this place inside DD4hep for me is strange. I do not know why DD4hep work with primary particles. We need making a ticket for them.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21580/summary.html
COMMIT: 789f0cf
CMSSW: CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7436/21580/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21580/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21580/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EML.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMM.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMN.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_INCLXX_EMM.cc: In constructor 'FTFPCMS_INCLXX_EMM::FTFPCMS_INCLXX_EMM(const edm::ParameterSet&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_INCLXX_EMM.cc:44:69: error: no matching function for call to 'G4HadronPhysicsINCLXX::G4HadronPhysicsINCLXX(int&, bool, bool, bool)'
   44 |     RegisterPhysics(new G4HadronPhysicsINCLXX(ver, true, false, true));
      |                                                                     ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_INCLXX_EMM.cc:13:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/geant4/10.7ref09-52277455525b03490232ae7df0764a7c/include/Geant4/G4HadronPhysicsINCLXX.hh:66:5: note: candidate: 'G4HadronPhysicsINCLXX::G4HadronPhysicsINCLXX(const G4String&, G4bool, G4bool, G4bool)'
   66 |     G4HadronPhysicsINCLXX(const G4String& name, const G4bool quasiElastic=true, const G4bool neutronHP=false, const G4bool ftfp=false);


@smuzaffar
Copy link
Contributor

@civanch looks like dd4hep is now ready for geant4 version 11 but now we need cmssw changes for G4 11 (see build errors https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21580/build-logs/ )

@civanch
Copy link
Contributor

civanch commented Jan 10, 2022

@smuzaffar , thanks! will try to address this issue shortly.

@civanch
Copy link
Contributor

civanch commented Jan 10, 2022

@smuzaffar , #36659 should fix the problem.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_3_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21613/summary.html
COMMIT: 789f0cf
CMSSW: CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7436/21613/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21613/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21613/git-merge-result

Build

I found compilation error when building:

>> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/TrackingVerbose/src/TrackingVerboseAction.cc
>> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-06-2300/src/SimG4Core/TrackingVerbose/src/module.cc
>> Building  big object file tmp/slc7_amd64_gcc10/src/SimG4Core/TrackingVerbose/src/SimG4CoreTrackingVerbose/bigobj/SimG4CoreTrackingVerbose.obj
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/SimG4Core/TrackingVerbose/src/SimG4CoreTrackingVerbose/libSimG4CoreTrackingVerbose.so
/cvmfs/cms-ib.cern.ch/nweek-02714/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lSimG4CoreApplication
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/SimG4Core/TrackingVerbose/src/SimG4CoreTrackingVerbose/libSimG4CoreTrackingVerbose.so] Error 1
Leaving library rule at SimG4Core/TrackingVerbose
>> Entering Package SimG4Core/GeometryProducer
>> Leaving Package SimG4Core/GeometryProducer
>> Package SimG4Core/GeometryProducer built


@smuzaffar
Copy link
Contributor

@civanch , there are still few more errors, can you please look in to these too https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21613/build-logs/ ?

@civanch
Copy link
Contributor

civanch commented Jan 11, 2022

I am working on it.

@civanch
Copy link
Contributor

civanch commented Jan 21, 2022

@smuzaffar , is it possible to start test with #36737 ?

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_3_G4VECGEOM_X

@civanch , I have updated the test parameters #7436 (comment) to use cms-sw/cmssw#36737 now

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21887/summary.html
COMMIT: 789f0cf
CMSSW: CMSSW_12_3_G4VECGEOM_X_2022-01-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7436/21887/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-20-2300/src/TrackPropagation/Geant4e/plugins/GeantPropagatorESProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-20-2300/src/TrackPropagation/Geant4e/plugins/module.cc
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/TrackPropagation/Geant4e/plugins/TrackPropagatorsGeant4ePlugins/libTrackPropagatorsGeant4ePlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02716/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lTrackPropagationGeant4e
/cvmfs/cms-ib.cern.ch/nweek-02716/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lG4visXXX
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/TrackPropagation/Geant4e/plugins/TrackPropagatorsGeant4ePlugins/libTrackPropagatorsGeant4ePlugins.so] Error 1
Leaving library rule at src/TrackPropagation/Geant4e/plugins
Entering library rule at TrackPropagation/Geant4e
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_G4VECGEOM_X_2022-01-20-2300/src/TrackPropagation/Geant4e/src/Geant4ePropagator.cc
>> Building  shared library tmp/slc7_amd64_gcc10/src/TrackPropagation/Geant4e/src/TrackPropagationGeant4e/libTrackPropagationGeant4e.so


@cmsbuild
Copy link
Contributor

Pull request #7436 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21903/summary.html
COMMIT: 6ded736
CMSSW: CMSSW_12_3_X_2022-01-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7436/21903/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21903/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c16f/21903/git-merge-result

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • You potentially added 5300 lines to the logs
  • Reco comparison results: 65210 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3464860
  • DQMHistoTests: Total failures: 928249
  • DQMHistoTests: Total nulls: 298
  • DQMHistoTests: Total successes: 2536291
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.651 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 0.111 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -1.295 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 3.194 KiB SiStrip/MechanicalView
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 15 / 42 workflows

@civanch
Copy link
Contributor

civanch commented Jan 23, 2022

@smuzaffar , it seems that the test is OK.

@smuzaffar
Copy link
Contributor

@civanch , yes tests result look good. I will merge this once cms-sw/cmssw#36737 is merged.

@smuzaffar smuzaffar merged commit 5bf8c33 into cms-sw:IB/CMSSW_12_3_X/geant4_vecgeom Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants