-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-alca213 Complete the validation of the new AlCaReco for HcalIsoTrackFilter #36621
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27611
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27612
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37caff/21512/summary.html Comparison SummarySummary:
|
@@ -4,7 +4,7 @@ | |||
#AlCaReco filtering for HCAL isotrk: | |||
#------------------------------------------------ | |||
|
|||
from Calibration.HcalAlCaRecoProducers.alcaHcalIsotrkProducer_cfi import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed? The .cfi should be used, and it should be created by the fillDescribtion method in the producer .cc file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some parameters which depend on the run period. The condition of EE changed over years due to radiation damage. So we need to modify some of the parameters which are ERA dependent. So all parameters are defined through the cfi created by fillDescription and the ERA dependence is put in the cff file which started from the cfi file.
@@ -42,6 +42,7 @@ class HcalIsoTrackAnalyzer : public edm::one::EDAnalyzer<edm::one::WatchRuns, ed | |||
void beginRun(edm::Run const&, edm::EventSetup const&) override {} | |||
void endRun(edm::Run const&, edm::EventSetup const&) override; | |||
|
|||
edm::Service<TFileService> fs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since now this is a member, it should have the nomenclature of fs_
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am moving this in the class method where it is needed
@@ -133,6 +133,7 @@ class HcalIsoTrkAnalyzer : public edm::one::EDAnalyzer<edm::one::WatchRuns, edm: | |||
bool notaMuon(const reco::Track* pTrack0, const edm::Handle<reco::MuonCollection>& muonh); | |||
|
|||
l1t::L1TGlobalUtil* l1GtUtils_; | |||
edm::Service<TFileService> fs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edm::Service<TFileService> fs; | |
edm::Service<TFileService> fs_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done the same way as above
@cmsbuild Please test |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27675
|
Pull request #36621 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37caff/21571/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Complete the validation of the new AlCaReco for HcalIsoTrackFilter
PR validation:
Use the runTheMatrix test workflows and cfg's in the test areas
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special