Run3-alca213 Complete the validation of the new AlCaReco for HcalIsoTrackFilter #36621

bsunanda · 2022-01-01T20:01:17Z

PR description:

Complete the validation of the new AlCaReco for HcalIsoTrackFilter

PR validation:

Use the runTheMatrix test workflows and cfg's in the test areas

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2022-01-01T20:07:41Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27611

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27611/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27611/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-01-01T20:19:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27612

This PR adds an extra 40KB to repository

cmsbuild · 2022-01-01T20:20:12Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers (alca)
Calibration/HcalCalibAlgos (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-01-01T20:50:20Z

@cmsbuild Please test

cmsbuild · 2022-01-02T00:31:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37caff/21512/summary.html
COMMIT: 779372b
CMSSW: CMSSW_12_3_X_2022-01-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36621/21512/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461692
DQMHistoTests: Total failures: 17
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461652
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

tvami · 2022-01-03T11:22:58Z

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalIsoTrkProducerFilter_cff.py

@@ -4,7 +4,7 @@
 #AlCaReco filtering for HCAL isotrk:
 #------------------------------------------------

-from Calibration.HcalAlCaRecoProducers.alcaHcalIsotrkProducer_cfi import *


Why is this changed? The .cfi should be used, and it should be created by the fillDescribtion method in the producer .cc file

There are some parameters which depend on the run period. The condition of EE changed over years due to radiation damage. So we need to modify some of the parameters which are ERA dependent. So all parameters are defined through the cfi created by fillDescription and the ERA dependence is put in the cff file which started from the cfi file.

tvami · 2022-01-04T00:42:07Z

Calibration/HcalCalibAlgos/plugins/HcalIsoTrackAnalyzer.cc

@@ -42,6 +42,7 @@ class HcalIsoTrackAnalyzer : public edm::one::EDAnalyzer<edm::one::WatchRuns, ed
  void beginRun(edm::Run const&, edm::EventSetup const&) override {}
  void endRun(edm::Run const&, edm::EventSetup const&) override;

+  edm::Service<TFileService> fs;


I think since now this is a member, it should have the nomenclature of fs_, no?

I am moving this in the class method where it is needed

tvami · 2022-01-04T00:43:48Z

Calibration/HcalCalibAlgos/plugins/HcalIsoTrkAnalyzer.cc

@@ -133,6 +133,7 @@ class HcalIsoTrkAnalyzer : public edm::one::EDAnalyzer<edm::one::WatchRuns, edm:
  bool notaMuon(const reco::Track* pTrack0, const edm::Handle<reco::MuonCollection>& muonh);

  l1t::L1TGlobalUtil* l1GtUtils_;
+  edm::Service<TFileService> fs;


Suggested change

edm::Service<TFileService> fs;

edm::Service<TFileService> fs_;

Done the same way as above

bsunanda · 2022-01-04T13:28:01Z

@cmsbuild Please test

bsunanda · 2022-01-08T19:57:12Z

@cmsbuild Please test

cmsbuild · 2022-01-08T20:03:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36621/27675

This PR adds an extra 44KB to repository

cmsbuild · 2022-01-08T20:03:53Z

Pull request #36621 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

cmsbuild · 2022-01-08T23:48:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37caff/21571/summary.html
COMMIT: 2eb3268
CMSSW: CMSSW_12_3_X_2022-01-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36621/21571/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461659
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461620
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

tvami · 2022-01-10T00:47:57Z

+alca

cmsbuild · 2022-01-10T00:48:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-01-10T01:26:39Z

+1

cmsbuild added this to the CMSSW_12_3_X milestone Jan 1, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jan 1, 2022

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jan 1, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 1, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 1, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 2, 2022

tvami reviewed Jan 3, 2022

View reviewed changes

tvami reviewed Jan 4, 2022

View reviewed changes

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Jan 4, 2022

cmsbuild removed the tests-pending label Jan 4, 2022

cmsbuild added alca-pending code-checks-pending pending-signatures tests-pending and removed alca-approved fully-signed tests-approved code-checks-approved labels Jan 8, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 8, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jan 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 10, 2022

cmsbuild merged commit caf9b46 into cms-sw:master Jan 10, 2022

This was referenced Jan 10, 2022

Update Geant4 to 10.7ref09 cms-sw/cmsdist#7436

Merged

Updated boost to 1.78 cms-sw/cmsdist#7529

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca213 Complete the validation of the new AlCaReco for HcalIsoTrackFilter #36621

Run3-alca213 Complete the validation of the new AlCaReco for HcalIsoTrackFilter #36621

bsunanda commented Jan 1, 2022

cmsbuild commented Jan 1, 2022

cmsbuild commented Jan 1, 2022

cmsbuild commented Jan 1, 2022

bsunanda commented Jan 1, 2022

cmsbuild commented Jan 2, 2022

tvami Jan 3, 2022

bsunanda Jan 3, 2022

tvami Jan 4, 2022

bsunanda Jan 4, 2022

tvami Jan 4, 2022

bsunanda Jan 4, 2022

bsunanda commented Jan 4, 2022

bsunanda commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

tvami commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

qliphy commented Jan 10, 2022

	edm::Service<TFileService> fs;
	edm::Service<TFileService> fs_;

Run3-alca213 Complete the validation of the new AlCaReco for HcalIsoTrackFilter #36621

Run3-alca213 Complete the validation of the new AlCaReco for HcalIsoTrackFilter #36621

Conversation

bsunanda commented Jan 1, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 1, 2022

cmsbuild commented Jan 1, 2022

cmsbuild commented Jan 1, 2022

bsunanda commented Jan 1, 2022

cmsbuild commented Jan 2, 2022

Comparison Summary

tvami Jan 3, 2022

Choose a reason for hiding this comment

bsunanda Jan 3, 2022

Choose a reason for hiding this comment

tvami Jan 4, 2022

Choose a reason for hiding this comment

bsunanda Jan 4, 2022

Choose a reason for hiding this comment

tvami Jan 4, 2022

Choose a reason for hiding this comment

bsunanda Jan 4, 2022

Choose a reason for hiding this comment

bsunanda commented Jan 4, 2022

bsunanda commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

Comparison Summary

tvami commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

qliphy commented Jan 10, 2022