Fix HcalTestThreshold.cc: validId is used before declaration

[iarspider]

Fixes the following error:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/49cdc564aa5d41cf44306c286f822fc4/opt/cmssw/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_3_DBG_X_2022-01-20-2300/src/Calibration/HcalCalibAlgos/test/HcalTestThreshold.cc: In member function 'virtual void HcalTestThreshold::analyze(const edm::Event&, const edm::EventSetup&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/49cdc564aa5d41cf44306c286f822fc4/opt/cmssw/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_3_DBG_X_2022-01-20-2300/src/Calibration/HcalCalibAlgos/test/HcalTestThreshold.cc:99:57: error: 'validId' was not declared in this scope
    99 |   edm::LogVerbatim("HcalIsoTrack") << "\n\nList of " << validId.size() << " valid DetId's of EE";
      |                                                         ^~~~~~~
  gmake: *** [tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/test/CalibrationHcalCalibAlgosTest/HcalTestThreshold.cc.o] Error 1

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

@iarspider, CMSSW_12_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36767/27901

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Calibration/HcalCalibAlgos (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5accc7/21880/summary.html
COMMIT: 28c4f5c
CMSSW: CMSSW_12_3_X_2022-01-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36767/21880/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3464821
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[tvami]

type bug-fix

[tvami]

@iarspider can you please modify the PR title to be more descriptive of what the "update" is about? Thanks!

[iarspider]

@tvami ok now?

[tvami]

+alca

• code change in line w PR description
• failure in Jenkins test is known and not connected to this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• The fix applies to a DEBUG section of code in a \test area: as such it cannot affect the output of any workflow, and therefore it is suitable to be merged now for 12_3_0_pre4, even if that pre-release is only intended to integrate the updates/fixes to the Run3 geometry on top of pre3

[perrotta]

merge