Run3-sim101A Remove some compilation warnings in classes from SimCalorimetry and SimGeneral

[bsunanda]

PR description:

Remove some compilation warnings in classes from SimCalorimetry (EcalEBTrigPrimProducers, EcalSimProducers, EcalTrigPrimProducer) and SimGeneral (MixingModukem NoiseGenerators, PileUpInformation)

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36598/27569

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimCalorimetry/EcalEBTrigPrimProducers (upgrade, l1)
• SimCalorimetry/EcalSimProducers (simulation)
• SimCalorimetry/EcalTrigPrimProducers (l1)
• SimGeneral/MixingModule (simulation)
• SimGeneral/NoiseGenerators (simulation)
• SimGeneral/PileupInformation (simulation)

@civanch, @rekovic, @epalencia, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@rchatter, @rovere, @argiro, @makortel, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b35a11/21485/summary.html
COMMIT: 92ef9f8
CMSSW: CMSSW_12_3_X_2021-12-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36598/21485/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461692
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3461664
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[civanch]

+1

pure technical

[cecilecaillol]

+l1

[bsunanda]

@srimanob Please approve

[srimanob]

+Upgrade

Technical PR to avoid compilation warnings. No change is expected. PR test runs fine, and shows no change.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1