Drop type specs for Alignment and EGamma #36635

NiharSaha · 2022-01-05T16:51:36Z

PR description:

Drop type specs in DQMOffline/Alignment, DQMOffline/EGamma python configuration files.

Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone

PR validation:

runTheMatrix.py -l limited -i all --ibeos

cmsbuild · 2022-01-05T16:57:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36635/27640

This PR adds an extra 20KB to repository

cmsbuild · 2022-01-05T16:58:05Z

A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master.

It involves the following packages:

DQMOffline/Alignment (dqm)
DQMOffline/EGamma (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rovere, @lecriste, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2022-01-05T19:11:54Z

DQMOffline/EGamma/python/photonAnalyzer_cfi.py

@@ -12,6 +12,8 @@

    barrelRecHitProducer = cms.InputTag('reducedEcalRecHitsEB'),								
    endcapRecHitProducer = cms.InputTag('reducedEcalRecHitsEE'),
+    barrelRecHitCollection = cms.InputTag (''),


@NiharSaha why these additions?

barrelRecHitCollection and endcapRecHitCollection both are in cosmicPhotonAnalyzer_cfi.py, but were not defined photonAnalyzer_cfi.py from where they were imported. Please correct me if I am wrong!

I believe they can be dropped in both files since the parameter indeed does not exist in the class:

cmssw/DQMOffline/EGamma/plugins/PhotonAnalyzer.cc

Lines 20 to 46 in 37bf1fa

fName_ = pset.getParameter<string>("analyzerName");

prescaleFactor_ = pset.getUntrackedParameter<int>("prescaleFactor", 1);

photon_token_ = consumes<vector<reco::Photon> >(pset.getParameter<edm::InputTag>("phoProducer"));

barrelRecHit_token_ = consumes<edm::SortedCollection<EcalRecHit, edm::StrictWeakOrdering<EcalRecHit> > >(

pset.getParameter<edm::InputTag>("barrelRecHitProducer"));

PhotonIDLoose_token_ = consumes<edm::ValueMap<bool> >(pset.getParameter<edm::InputTag>("photonIDLoose"));

PhotonIDTight_token_ = consumes<edm::ValueMap<bool> >(pset.getParameter<edm::InputTag>("photonIDTight"));

endcapRecHit_token_ = consumes<edm::SortedCollection<EcalRecHit, edm::StrictWeakOrdering<EcalRecHit> > >(

pset.getParameter<edm::InputTag>("endcapRecHitProducer"));

triggerEvent_token_ = consumes<trigger::TriggerEvent>(pset.getParameter<edm::InputTag>("triggerEvent"));

offline_pvToken_ = consumes<reco::VertexCollection>(

pset.getUntrackedParameter<edm::InputTag>("offlinePV", edm::InputTag("offlinePrimaryVertices")));

minPhoEtCut_ = pset.getParameter<double>("minPhoEtCut");

photonMaxEta_ = pset.getParameter<double>("maxPhoEta");

invMassEtCut_ = pset.getParameter<double>("invMassEtCut");

cutStep_ = pset.getParameter<double>("cutStep");

numberOfSteps_ = pset.getParameter<int>("numberOfSteps");

useBinning_ = pset.getParameter<bool>("useBinning");

useTriggerFiltering_ = pset.getParameter<bool>("useTriggerFiltering");

minimalSetOfHistos_ = pset.getParameter<bool>("minimalSetOfHistos");

excludeBkgHistos_ = pset.getParameter<bool>("excludeBkgHistos");

standAlone_ = pset.getParameter<bool>("standAlone");

isolationStrength_ = pset.getParameter<int>("isolationStrength");

isHeavyIon_ = pset.getUntrackedParameter<bool>("isHeavyIon", false);

The *RecHitProducer are used instead

cmsbuild · 2022-01-06T13:21:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36635/27655

This PR adds an extra 20KB to repository

cmsbuild · 2022-01-06T13:21:36Z

Pull request #36635 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2022-01-07T09:13:41Z

please test

cmsbuild · 2022-01-07T10:14:40Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2a21b/21559/summary.html
COMMIT: 65e2664
CMSSW: CMSSW_12_3_X_2022-01-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36635/21559/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

38634.0

----- Begin Fatal Exception 07-Jan-2022 09:50:56 UTC-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_6_step'
   [2] Calling method for module SuperClusterMerger/'mergedSuperClustersHGC'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::SuperCluster>
Looking for module label: particleFlowSuperClusterHGCal
Looking for productInstanceName:  

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

23234.0

----- Begin Fatal Exception 07-Jan-2022 09:52:46 UTC-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_6_step'
   [2] Calling method for module SuperClusterMerger/'mergedSuperClustersHGC'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::SuperCluster>
Looking for module label: particleFlowSuperClusterHGCal
Looking for productInstanceName:  

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

35034.0

----- Begin Fatal Exception 07-Jan-2022 09:52:58 UTC-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_6_step'
   [2] Calling method for module SuperClusterMerger/'mergedSuperClustersHGC'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::SuperCluster>
Looking for module label: particleFlowSuperClusterHGCal
Looking for productInstanceName:  

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

jfernan2 · 2022-01-09T10:18:28Z

DQMOffline/EGamma/python/electronAnalyzerSequence_cff.py

+mergedSuperClustersHGC = mergedSuperClusters.clone(
+    src = (
+        ("particleFlowSuperClusterECAL:particleFlowSuperClusterECALBarrel"),
+        ("particleFlowSuperClusterHGCal: ")


("particleFlowSuperClusterHGCal")

To avoid the crash

jfernan2 · 2022-01-09T10:45:57Z

please test

cmsbuild · 2022-01-09T10:50:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36635/27684

This PR adds an extra 12KB to repository

cmsbuild · 2022-01-09T10:51:02Z

Pull request #36635 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

cmsbuild · 2022-01-09T13:42:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2a21b/21576/summary.html
COMMIT: 82a4a57
CMSSW: CMSSW_12_3_X_2022-01-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36635/21576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461659
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461620
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-01-09T13:44:26Z

+1

cmsbuild · 2022-01-09T13:44:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-01-09T18:24:00Z

+1

Drop type specs for Alignment and EGamma

e5882fe

cmsbuild added this to the CMSSW_12_3_X milestone Jan 5, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Jan 5, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 5, 2022

jfernan2 reviewed Jan 5, 2022

View reviewed changes

Update cosmicPhotonAnalyzer_cfi.py

f9cc5b8

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 6, 2022

Update photonAnalyzer_cfi.py

65e2664

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 6, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 7, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 7, 2022

jfernan2 reviewed Jan 9, 2022

View reviewed changes

Update electronAnalyzerSequence_cff.py

82a4a57

cmsbuild removed tests-rejected code-checks-approved labels Jan 9, 2022

cmsbuild added code-checks-pending tests-pending labels Jan 9, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 9, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 9, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 9, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 9, 2022

cmsbuild merged commit 20f76c4 into cms-sw:master Jan 9, 2022

cmsbuild mentioned this pull request Jan 10, 2022

Update Geant4 to 10.7ref09 cms-sw/cmsdist#7436

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop type specs for Alignment and EGamma #36635

Drop type specs for Alignment and EGamma #36635

NiharSaha commented Jan 5, 2022

cmsbuild commented Jan 5, 2022

cmsbuild commented Jan 5, 2022

jfernan2 Jan 5, 2022

NiharSaha Jan 5, 2022

jfernan2 Jan 6, 2022

cmsbuild commented Jan 6, 2022

cmsbuild commented Jan 6, 2022

jfernan2 commented Jan 7, 2022

cmsbuild commented Jan 7, 2022

jfernan2 Jan 9, 2022

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

perrotta commented Jan 9, 2022

	fName_ = pset.getParameter<string>("analyzerName");
	prescaleFactor_ = pset.getUntrackedParameter<int>("prescaleFactor", 1);

	photon_token_ = consumes<vector<reco::Photon> >(pset.getParameter<edm::InputTag>("phoProducer"));
	barrelRecHit_token_ = consumes<edm::SortedCollection<EcalRecHit, edm::StrictWeakOrdering<EcalRecHit> > >(
	pset.getParameter<edm::InputTag>("barrelRecHitProducer"));
	PhotonIDLoose_token_ = consumes<edm::ValueMap<bool> >(pset.getParameter<edm::InputTag>("photonIDLoose"));
	PhotonIDTight_token_ = consumes<edm::ValueMap<bool> >(pset.getParameter<edm::InputTag>("photonIDTight"));
	endcapRecHit_token_ = consumes<edm::SortedCollection<EcalRecHit, edm::StrictWeakOrdering<EcalRecHit> > >(
	pset.getParameter<edm::InputTag>("endcapRecHitProducer"));
	triggerEvent_token_ = consumes<trigger::TriggerEvent>(pset.getParameter<edm::InputTag>("triggerEvent"));
	offline_pvToken_ = consumes<reco::VertexCollection>(
	pset.getUntrackedParameter<edm::InputTag>("offlinePV", edm::InputTag("offlinePrimaryVertices")));

	minPhoEtCut_ = pset.getParameter<double>("minPhoEtCut");
	photonMaxEta_ = pset.getParameter<double>("maxPhoEta");
	invMassEtCut_ = pset.getParameter<double>("invMassEtCut");
	cutStep_ = pset.getParameter<double>("cutStep");
	numberOfSteps_ = pset.getParameter<int>("numberOfSteps");
	useBinning_ = pset.getParameter<bool>("useBinning");
	useTriggerFiltering_ = pset.getParameter<bool>("useTriggerFiltering");
	minimalSetOfHistos_ = pset.getParameter<bool>("minimalSetOfHistos");
	excludeBkgHistos_ = pset.getParameter<bool>("excludeBkgHistos");
	standAlone_ = pset.getParameter<bool>("standAlone");
	isolationStrength_ = pset.getParameter<int>("isolationStrength");
	isHeavyIon_ = pset.getUntrackedParameter<bool>("isHeavyIon", false);

Drop type specs for Alignment and EGamma #36635

Drop type specs for Alignment and EGamma #36635

Conversation

NiharSaha commented Jan 5, 2022

PR description:

PR validation:

cmsbuild commented Jan 5, 2022

cmsbuild commented Jan 5, 2022

jfernan2 Jan 5, 2022

Choose a reason for hiding this comment

NiharSaha Jan 5, 2022

Choose a reason for hiding this comment

jfernan2 Jan 6, 2022

Choose a reason for hiding this comment

cmsbuild commented Jan 6, 2022

cmsbuild commented Jan 6, 2022

jfernan2 commented Jan 7, 2022

cmsbuild commented Jan 7, 2022

RelVals

jfernan2 Jan 9, 2022

Choose a reason for hiding this comment

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

Comparison Summary

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

perrotta commented Jan 9, 2022