-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop type specs for Alignment and EGamma #36635
Drop type specs for Alignment and EGamma #36635
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36635/27640
|
A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -12,6 +12,8 @@ | |||
|
|||
barrelRecHitProducer = cms.InputTag('reducedEcalRecHitsEB'), | |||
endcapRecHitProducer = cms.InputTag('reducedEcalRecHitsEE'), | |||
barrelRecHitCollection = cms.InputTag (''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NiharSaha why these additions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
barrelRecHitCollection
and endcapRecHitCollection
both are in cosmicPhotonAnalyzer_cfi.py, but were not defined photonAnalyzer_cfi.py from where they were imported. Please correct me if I am wrong!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe they can be dropped in both files since the parameter indeed does not exist in the class:
cmssw/DQMOffline/EGamma/plugins/PhotonAnalyzer.cc
Lines 20 to 46 in 37bf1fa
fName_ = pset.getParameter<string>("analyzerName"); | |
prescaleFactor_ = pset.getUntrackedParameter<int>("prescaleFactor", 1); | |
photon_token_ = consumes<vector<reco::Photon> >(pset.getParameter<edm::InputTag>("phoProducer")); | |
barrelRecHit_token_ = consumes<edm::SortedCollection<EcalRecHit, edm::StrictWeakOrdering<EcalRecHit> > >( | |
pset.getParameter<edm::InputTag>("barrelRecHitProducer")); | |
PhotonIDLoose_token_ = consumes<edm::ValueMap<bool> >(pset.getParameter<edm::InputTag>("photonIDLoose")); | |
PhotonIDTight_token_ = consumes<edm::ValueMap<bool> >(pset.getParameter<edm::InputTag>("photonIDTight")); | |
endcapRecHit_token_ = consumes<edm::SortedCollection<EcalRecHit, edm::StrictWeakOrdering<EcalRecHit> > >( | |
pset.getParameter<edm::InputTag>("endcapRecHitProducer")); | |
triggerEvent_token_ = consumes<trigger::TriggerEvent>(pset.getParameter<edm::InputTag>("triggerEvent")); | |
offline_pvToken_ = consumes<reco::VertexCollection>( | |
pset.getUntrackedParameter<edm::InputTag>("offlinePV", edm::InputTag("offlinePrimaryVertices"))); | |
minPhoEtCut_ = pset.getParameter<double>("minPhoEtCut"); | |
photonMaxEta_ = pset.getParameter<double>("maxPhoEta"); | |
invMassEtCut_ = pset.getParameter<double>("invMassEtCut"); | |
cutStep_ = pset.getParameter<double>("cutStep"); | |
numberOfSteps_ = pset.getParameter<int>("numberOfSteps"); | |
useBinning_ = pset.getParameter<bool>("useBinning"); | |
useTriggerFiltering_ = pset.getParameter<bool>("useTriggerFiltering"); | |
minimalSetOfHistos_ = pset.getParameter<bool>("minimalSetOfHistos"); | |
excludeBkgHistos_ = pset.getParameter<bool>("excludeBkgHistos"); | |
standAlone_ = pset.getParameter<bool>("standAlone"); | |
isolationStrength_ = pset.getParameter<int>("isolationStrength"); | |
isHeavyIon_ = pset.getUntrackedParameter<bool>("isHeavyIon", false); | |
The *RecHitProducer are used instead
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36635/27655
|
Pull request #36635 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
please test |
-1 Failed Tests: RelVals RelVals
|
mergedSuperClustersHGC = mergedSuperClusters.clone( | ||
src = ( | ||
("particleFlowSuperClusterECAL:particleFlowSuperClusterECALBarrel"), | ||
("particleFlowSuperClusterHGCal: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
("particleFlowSuperClusterHGCal")
To avoid the crash
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36635/27684
|
Pull request #36635 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2a21b/21576/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Drop type specs in DQMOffline/Alignment, DQMOffline/EGamma python configuration files.
Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone
PR validation:
runTheMatrix.py -l limited -i all --ibeos