Move GEM offline DQM files from DQMOffline/Muon to DQM/GEM

[seungjin-yang]

PR description:

• This PR moves GEM offline DQM files from DQMOffline/Muon to DQM/GEM for better packaging.
• In addition, this PR removes GEMOfflineMonitor because it has been replaced by GEMDigiSource and GEMRecHitSource since CMSSW_12_0_0_pre6.

PR validation:

Tested with the following wf:

• 11650.0: pp / Run3 / ZMM
• 35050.0: pp / Phase2 / ZMM
• 11654.0: cosmics / Run3 / CosmicsSPLoose
• 35054.0: cosmics / Phase2 / CosmicsSPLoose

It requires some modification to run the workflow with cosmics scenario option. See more details on the last page of this slide.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36627/27626

• This PR adds an extra 48KB to repository

• Found files with invalid states:

  • DQM/GEM/plugins/GEMOfflineMonitor.h:
    • Added: 2215f6e
    • Deleted: b39e8b2
  • DQM/GEM/plugins/GEMOfflineMonitor.cc:
    • Added: 2215f6e
    • Deleted: b39e8b2

[cmsbuild]

A new Pull Request was created by @seungjin-yang for master.

It involves the following packages:

• DQM/GEM (dqm)
• DQMOffline/Configuration (dqm)
• DQMOffline/Muon (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @barvic, @bellan, @threus, @abbiendi, @Fedespring, @watson-ij, @calderona, @HuguesBrun, @jhgoh, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[seungjin-yang]

@jshlee @quark2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36627/27627

• This PR adds an extra 52KB to repository

• Found files with invalid states:

  • DQM/GEM/plugins/GEMOfflineMonitor.h:
    • Added: 2215f6e
    • Deleted: b39e8b2
  • DQM/GEM/plugins/GEMOfflineMonitor.cc:
    • Added: 2215f6e
    • Deleted: b39e8b2

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMOffline/Configuration/python/DQMOfflineCosmics_SecondStep_cff.py modified in PR(s): Adding modules for tag-and-probe efficiency computation in DQMOffline #36276
  • File DQMOffline/Configuration/python/DQMOfflineCosmics_cff.py modified in PR(s): Adding modules for tag-and-probe efficiency computation in DQMOffline #36276

[cmsbuild]

Pull request #36627 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfbd3f/21532/summary.html
COMMIT: 8b9d796
CMSSW: CMSSW_12_3_X_2022-01-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36627/21532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461692
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3461664
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jfernan2]

Thanks @seungjin-yang
I tried to run it here since I thought some modification was needed but I realized now it is not

[jfernan2]

test parameters:

• workflows = 35054.0
• addpkg = DQM/Integration

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfbd3f/21543/summary.html
COMMIT: 8b9d796
CMSSW: CMSSW_12_3_X_2022-01-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36627/21543/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

[jfernan2]

test parameters:

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfbd3f/21549/summary.html
COMMIT: 8b9d796
CMSSW: CMSSW_12_3_X_2022-01-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36627/21549/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461637
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1