-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GEM offline DQM files from DQMOffline/Muon to DQM/GEM #36627
Move GEM offline DQM files from DQMOffline/Muon to DQM/GEM #36627
Conversation
…_3_0_pre4` in favor of `GEMDigiSource` and `GEMRecHitSource`.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36627/27626 |
A new Pull Request was created by @seungjin-yang for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36627/27627
|
Pull request #36627 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfbd3f/21532/summary.html Comparison SummarySummary:
|
Thanks @seungjin-yang |
test parameters:
|
please test |
-1 Failed Tests: RelVals RelVals |
test parameters: |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfbd3f/21549/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
DQMOffline/Muon
toDQM/GEM
for better packaging.GEMOfflineMonitor
because it has been replaced byGEMDigiSource
andGEMRecHitSource
since CMSSW_12_0_0_pre6.PR validation:
Tested with the following wf:
It requires some modification to run the workflow with cosmics scenario option. See more details on the last page of this slide.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A