-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop type specs for L1Trigger, Muon and RecoB #36667
Drop type specs for L1Trigger, Muon and RecoB #36667
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36667/27708
|
A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master. It involves the following packages:
@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -45,11 +45,11 @@ | |||
l1tTauEmuDiff = l1tDiffHarvesting.clone( | |||
plotCfgs=cms.untracked.VPSet( | |||
cms.untracked.PSet( # EMU comparison |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be converted to a dict and drop type afterward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I have tried that, but it was showing error. That's why I left them unchanged. May I know if Pset->dist, then VPSet->??
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36667/27721 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36667/27721/cms-checkout-topic.log |
PR description:
Drop type specs in DQMOffline/L1Trigger, DQMOffline/Muon, DQMOffline/RecoB python configuration files.
Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone
PR validation:
runTheMatrix.py -l limited -i all --ibeos