Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop type specs for L1Trigger, Muon and RecoB #36667

Closed

Conversation

NiharSaha
Copy link
Contributor

PR description:

Drop type specs in DQMOffline/L1Trigger, DQMOffline/Muon, DQMOffline/RecoB python configuration files.

Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone

PR validation:

runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36667/27708

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master.

It involves the following packages:

  • DQMOffline/L1Trigger (dqm, l1)
  • DQMOffline/Muon (dqm)
  • DQMOffline/RecoB (dqm)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @barvic, @JyothsnaKomaragiri, @abbiendi, @sscruz, @jhgoh, @calderona, @cericeci, @HuguesBrun, @Fedespring, @ptcox, @andrzejnovak, @demuller, @trocino, @bellan, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@@ -45,11 +45,11 @@
l1tTauEmuDiff = l1tDiffHarvesting.clone(
plotCfgs=cms.untracked.VPSet(
cms.untracked.PSet( # EMU comparison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be converted to a dict and drop type afterward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have tried that, but it was showing error. That's why I left them unchanged. May I know if Pset->dist, then VPSet->??

@jfernan2
Copy link
Contributor

@perrotta @qliphy the bot reports conflicts in this branch, do you know how to check those conflicts? They seem to not be reported

@perrotta
Copy link
Contributor

@perrotta @qliphy the bot reports conflicts in this branch, do you know how to check those conflicts? They seem to not be reported

Those configs have been moved away by #36627
Please rebase and apply the updates to the files in the new location

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants