Fixed static analyzer warnings in SimG4Core/Notification and clean-up Alignment/LaserAlignmentSimulation

[civanch]

PR description:

This PR only fixing static analyzer warnings in SimG4Core/Notification and fix the compilation problem for the new Geant4 11.0 in Alignment/LaserAlignmentSimulation. The last fix is expected to work both for Geant4 10.7 (current CMS default) and for Geant4 11.0.

Should not affect results.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR: NO

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36737/27838

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• Alignment/LaserAlignmentSimulation (alca)
• SimG4Core/Notification (simulation)

@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@adewit, @makortel, @cvuosalo, @rovere, @bsunanda, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4886bc/21779/summary.html
COMMIT: f493738
CMSSW: CMSSW_12_3_X_2022-01-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36737/21779/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3464833
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[francescobrivio]

+alca

• techinical from the alca point of view
• failure in 4.76 input is unrelated to this PR and shows up in every PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Besides the bug pointed out here, that can be easily fixed, this PR does not "fix" any static analyzer warning: they are all still there ("Returning null reference"), and mostly due to the fact that G4Exception actually throws, even if it is not known to the static analyzer.
I think we could simply ingnore those SA warnings from GenParticleInfoExtractor and NewTrackAction, because we know that they are not relevant; while I would concentrate of the possibility of returning a null pointer in TrackInformationExtractor, which is not fixed here and if deemed to represent an issue it should be addressed somehow (or also ignored if, in the contrary, returning a null pointer does not bother).

[civanch]

please test

[tvami]

@civanch could you please include SimG4Core/Notification and Alignment/LaserAlignmentSimulation in the PR title? The current title is somewhat generic. Thanks!

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4886bc/21883/summary.html
COMMIT: a4ef2e9
CMSSW: CMSSW_12_3_X_2022-01-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36737/21883/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3464826
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• with the remark of renaming the PR

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@perrotta , it seems all concerns are resolved and this PR is OK.

[perrotta]

+1

[perrotta]

merge