-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed static analyzer warnings in SimG4Core/Notification and clean-up Alignment/LaserAlignmentSimulation #36737
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36737/27838
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages:
@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
+1 |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the bug pointed out here, that can be easily fixed, this PR does not "fix" any static analyzer warning: they are all still there ("Returning null reference"), and mostly due to the fact that G4Exception
actually throws, even if it is not known to the static analyzer.
I think we could simply ingnore those SA warnings from GenParticleInfoExtractor
and NewTrackAction
, because we know that they are not relevant; while I would concentrate of the possibility of returning a null pointer in TrackInformationExtractor
, which is not fixed here and if deemed to represent an issue it should be addressed somehow (or also ignored if, in the contrary, returning a null pointer does not bother).
please test |
@civanch could you please include |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
+alca
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@perrotta , it seems all concerns are resolved and this PR is OK. |
+1 |
merge |
PR description:
This PR only fixing static analyzer warnings in SimG4Core/Notification and fix the compilation problem for the new Geant4 11.0 in Alignment/LaserAlignmentSimulation. The last fix is expected to work both for Geant4 10.7 (current CMS default) and for Geant4 11.0.
Should not affect results.
PR validation:
private
if this PR is a backport please specify the original PR and why you need to backport that PR: NO