Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEANT4][VECGEOM][10.7.2] Fixed Physics List destruction #7133

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

smuzaffar
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/geant4_vecgeom.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7133 was updated.

@smuzaffar smuzaffar merged commit e001aad into IB/CMSSW_12_0_X/geant4_vecgeom Jul 14, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da043d/16801/summary.html
COMMIT: 8b8d99e
CMSSW: CMSSW_12_0_G4VECGEOM_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7133/16801/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da043d/16801/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da043d/16801/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 51166 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 596305
  • DQMHistoTests: Total nulls: 250
  • DQMHistoTests: Total successes: 2189725
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.226 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.416 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 13 / 37 workflows

@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch July 16, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants