-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex110 Recover BHM placements in the dd4hep scenario #36648
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36648/27672
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36648/27673
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1948cc/21565/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@@ -0,0 +1,63 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should have a version number in the directory name, maybe Geometry/ForwardCommonData/data/forward/2021/v1/pixfwd.xml
?
Run3-gex110X Take care of Carl's comment for PR #36648
Hi @bsunanda does this need to be backported to 12_2_X? (Sorry if it was, I didnt see the link to this PR) |
This PR is backported and is apart of #36740 and is now documented in its history
…________________________________
From: Tamas Vami ***@***.***
Sent: 25 January 2022 02:19
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-gex110 Recover BHM placements in the dd4hep scenario (PR #36648)
Hi @bsunanda<https://github.com/bsunanda> does this need to be backported to 12_2_X? (Sorry if it was, I didnt see the link to this PR)
—
Reply to this email directly, view it on GitHub<#36648 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOSOPTFJ4C56BWFKKGTUXX3DLANCNFSM5LPKVMBA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
PR description:
Recover BHM placements in the dd4hep scenario
PR validation:
Use test workflows in Geometry/ForwardCommonData/test/python
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special