Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex110 Recover BHM placements in the dd4hep scenario #36648

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jan 7, 2022

PR description:

Recover BHM placements in the dd4hep scenario

PR validation:

Use test workflows in Geometry/ForwardCommonData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2022

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36648/27672

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36648/27673

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/ForwardCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 7, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1948cc/21565/summary.html
COMMIT: 6f8bd79
CMSSW: CMSSW_12_3_X_2022-01-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36648/21565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3461631
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jan 8, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jan 8, 2022

+1

@cmsbuild cmsbuild merged commit 9d03db5 into cms-sw:master Jan 8, 2022
@@ -0,0 +1,63 @@
<?xml version="1.0"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should have a version number in the directory name, maybe Geometry/ForwardCommonData/data/forward/2021/v1/pixfwd.xml?

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Jan 10, 2022
cmsbuild added a commit that referenced this pull request Jan 11, 2022
Run3-gex110X Take care of Carl's comment for PR #36648
@tvami
Copy link
Contributor

tvami commented Jan 25, 2022

Hi @bsunanda does this need to be backported to 12_2_X? (Sorry if it was, I didnt see the link to this PR)

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 25, 2022 via email

@perrotta
Copy link
Contributor

(Repeating also here for completeness)
I'm sorry @bsunanda , but none of the files modified here or in #36663 is included in the backport PR #36740
Could you please check, and provide the necessary amendments if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants