Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex110X Take care of Carl's comment for PR #36648 #36663

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

bsunanda
Copy link
Contributor

PR description:

Take care of Carl's comment for PR #36648. The comment is to move the file "pixfwd.xml" in something like "data/pixfwd/2021/v1/pixfwd.xml" which is done here.

PR validation:

Tested using workflows in the directory Geometry/ForwardCommonData/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36663/27699

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/ForwardCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8e290/21597/summary.html
COMMIT: a60aaf2
CMSSW: CMSSW_12_3_X_2022-01-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36663/21597/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461626
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jan 11, 2022

+1

Carl comment is implemented

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 11, 2022

+1

@tvami
Copy link
Contributor

tvami commented Jan 25, 2022

Hi @bsunanda does this need to be backported to 12_2_X? (Sorry if it was, I didnt see the link to this PR)

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 25, 2022 via email

@perrotta
Copy link
Contributor

This PR is backported and is apart of #36740 and is now documented in its history

I'm sorry @bsunanda , but none of the files modified here or in #36648 is included in the backport PR #36740
Could you please check, and provide the necessary amendments if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants