forked from microsoft/fluentui
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge fluentui into fork #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added keyboard shortcuts to UI builder * Removed array of active keys, using the event attributes * Code refactoring, added CHANGELOG entry
* feat: add useCSS hook * fix example path * fix example name * fix example names * fix lint issues * fix comment * Update packages/fluentui/react-bindings/test/hooks/useCSS-test.tsx Co-authored-by: Marija Najdova <[email protected]> * fix an assertion * use different selector for dev * add initial docs * improve examples, add RTL example * add a UT * fix merge issue Co-authored-by: Marija Najdova <[email protected]>
* fix(Menu): fix menu underlined focus style * fix(Menu): add changelog
* Moving selected component by d&d * Added changelog entry
* Removed props JSON from right side menu * Added CHANGELOG entry
* Fixed drop to the edge of iframe * Added CHANGELOG entry
Top's component Debug Frame was outside of iframe in UI builder, This PR is fixing the issue by moving the Debug frame to the bottom of the components that are at top of the iframe. * For component at the top DebugFrame menu is at the bottom * Added CHANGELOG entry
Edited component menu in UI builder (left side menu) * Keep component expanded, changed styling * Added Changelog entry
* Hide drop selector on scroll in canvas * Added Changelog entry
* merge conflicts * merge conflicts * merge conflicts * merge conflicts * fix prop helper * merge conflicts * WIP improve logging * merge conflicts * merge conflicts * merge conflicts * merge conflicts * WIP polishing * remove logging * add generic config mod * Change files * fix test * add snapshot testing * add snapshot * improve logging * new snaps * fix tests Co-authored-by: Trip Master <[email protected]>
* fix: apply badge appearance styling to control not host element * Change files
* optimizing northstar builds with more expressive lage config * update yarn.lock
…ge test script (#14547) * increase speed of v0 builds by making it participate in the per package test script * adding some gulp deps to make sure we don't run into no import/no-extraneous-dependencies issues * making e2e test happy within the package with babelconfig
* all pr-deploy-site to operate with partial builds * turn off progress plugin if in TF_BUILD & storybook! * typo! * Update pr-deploy-site.js
* Adding react-avatar. * Adding Avatar. * Updating Avatar to use raw sass. * blah. * more updates. * Changes. * Shorthand props now work * more updates. * Adding PersonaCoin example. * Cleanup. * Updating url. * changes * more changes. * Adding button. Renaming handledProp to mappedProp. * Addressing missing font definitions. Adding stylesheet support to themeprovider. * Addressing review feedback. * Merge branch 'master' of https://github.com/microsoft/fluentui into feat/avatar # Conflicts: # apps/test-bundles/package.json # packages/fluentui/react-northstar/src/components/Provider/Provider.tsx # yarn.lock * Undoing changes. * undoing a few more changes. * Updating react-compose dependency * Fixing broken things. * wip * Update packages/react-compose/src/utils.ts * converted all components to use react-compose * wip * Integrating useStylesheet. * Removing dupe stylesheets provider. * Merge branch 'master' of https://github.com/microsoft/fluentui into feat/avatar # Conflicts: # .vscode/settings.json # packages/fluentui/react-northstar/src/utils/felaStylisEnhancer.ts # packages/react-compose/etc/react-compose.api.md # packages/react-compose/package.json # packages/react-compose/src/compose.ts # packages/react-compose/src/types.ts # packages/react-compose/src/utils.ts # scripts/package.json # yarn.lock * updated readme * Change files * removing private * Change files * fixing lint. * Ensuring tests work. * Awesome. * updates. * yarn updates. Co-authored-by: Marija Najdova <[email protected]>
* Message bar fix * Default button with primary bug fix * Change files * WIP message bar * Waseem's suggestons clean up Co-authored-by: Jackie <[email protected]>
* chore(ListItem): refactor to avoid passing styles via "styles" * fix visual regressions * fix option name * add UTs * add imports * add changelog entry * fix another regression * fix statics * fix remaining UTs * use variables * add missing export
* Adding initial styling * Adding ms-grid and switching header cell from box to text * Using variables for datepicker styling * Removing IE11 compatibility * Adding changelog * Adding examples * PR feedback * Adding possibility to bold header cells * Move examples around * Further tests * Properly handling RTL * Adding styles for centering vertically of header * Pixel align * Pixel perfect * Theming * Adding visual tests * Updating visual tests * Updated formatting * Fixing background * Reshuffling styling variables * Adding propsType to calendarOpenState * Adding restricted dates examples * Fixing disabled styles * Fixing styling for focus * Fixing styles * Consolidating style variables * Further PR suggestions * PR suggestions * Reverting header cell * Properly navigating in restricted dates * Restricted dates navigation fixed * Removing navigation changes * Fixing localization strings * Fixing today screener test * PR suggestions * PR suggestoins Co-authored-by: Karel Rymes <[email protected]>
* add support for repathing and function dictionary * Change files * fix failing test * added isRegex to json file Co-authored-by: Trip Master <[email protected]>
#### Pull request checklist - [x] Addresses an existing issue: Fixes #12592 - [x] Include a change request file using `$ yarn change` #### Description of changes StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed. #### Focus areas to test (optional)
…age versions. (#14565) * Fixing lint error that's breaking master build due to mismatched package versions. * Change files * Adding @uifabric/icons to package.json. * Adding @fluentui/storybook dependency.
* result implemented * add logger interface * tweak no op result * Change files
* Updating to use latest iconset from latest versioned CDN. All filetypes are lowercase. SVGs for 20_1.5x are now available. * Change files
* Fixing recursive partial. * Change files * whitespace * updates * Updates. * Change files
* Fix Safari default outline on focused element * Update changelog
* feat(Breadcrumb): add base component * Update packages/fluentui/react-northstar/src/components/Breadcrumb/Breadcrumb.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * feat(Breadcrumb): expose slot * Revert "feat(Breadcrumb): expose slot" This reverts commit af78698. * feat(Breadcrumb): remove zone wrapper * feat(Breadcrumb): add changelog Co-authored-by: Oleksandr Fediashov <[email protected]>
* Area chart Redesigning * area chart redesigning * Area chart re design and implemented Caartesian * Change files * log files. * id and color updated * gap space updated and code structure updated * single leged click issue resolved Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
… next folder (#14809) * revert checkbox for v8 * add next basic example * udpate snapshots * Change files * screener * clean up link screener * update screeners * snaps * Change files * revert link stories * fix build * update snapshots
* expose and pass through popup props * Change files * actually a minor change * Remove header example * api updates
* Renaming SpinButton internalState interface to better reflect it's usage. * Change files * Removing an accidental change file.
#### Pull request checklist - [x] Addresses an existing issue: Fixes #13036 - [x] Include a change request file using `$ yarn change` #### Description of changes Callouts remain open when focus shifts outside the current window in which they're anchored. This PR uses a blur event handler to dismiss open callouts when the target window is blurred #### Focus areas to test Callout dismissal
) #### Pull request checklist - [x] Addresses an existing issue: Fixes #14671 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR adds an implementation for the `CompoundButton` component inside of the `@fluentui/react-button` package using our latest technology stack and patterns. #### Focus areas to test (optional)
* fix href * fix text underline * Change files * update screener
* feat(Breadcrumb): add base component * New component breadcrumbItem * New component breadcrumbDivider * Breadcrumb simple example in doc * Add styles to Breadcrumb item and divider * feat(Breadcrumb): fix behavior tests * feat(Breadcrumb): extract style variable * fix: `<div></div>` to `<></>` Co-authored-by: Oleksandr Fediashov <[email protected]> * fix: remove Update packages/fluentui/react-northstar/src/components/Breadcrumb/BreadcrumbItem.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * fix: remove `overrideStyles: true` Co-authored-by: Oleksandr Fediashov <[email protected]> * fix: remove wrapWithFocusZone for BreadcrumbDivider Update packages/fluentui/react-northstar/src/components/Breadcrumb/BreadcrumbDivider.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * fix: remove wrapWithFocusZone for BreadcrumbItem Co-authored-by: Oleksandr Fediashov <[email protected]> * fix: small syntax err * fix: use behaviorProps for accessibility Co-authored-by: Charles Assunção <[email protected]> * fix: use behaviorProps for accessibility Co-authored-by: Charles Assunção <[email protected]> * fix import Co-authored-by: Charles Assunção <[email protected]> * fix import Co-authored-by: Charles Assunção <[email protected]> * margin variable rename Co-authored-by: Oleksandr Fediashov <[email protected]> * margin variable rename Co-authored-by: Oleksandr Fediashov <[email protected]> * margin variable rename Co-authored-by: Oleksandr Fediashov <[email protected]> * feat(Breadcrumb): default example + icon divider example * feat(Breadcrumb): do + don't list * Update examples Co-authored-by: Oleksandr Fediashov <[email protected]> * Update examples Co-authored-by: Oleksandr Fediashov <[email protected]> * feat(Breadcrumb): move icon example to content * Update changelog Co-authored-by: Charles Assuncao <[email protected]> Co-authored-by: Oleksandr Fediashov <[email protected]>
* fix(Toolbar): allow popper propos in the overflow item * fix(Toolbar): add tests * fix(Toolbar): add changelog * Update packages/fluentui/react-northstar/test/specs/components/Toolbar/Toolbar-test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * Update packages/fluentui/react-northstar/test/specs/components/Toolbar/Toolbar-test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * Update packages/fluentui/react-northstar/test/specs/components/Toolbar/Toolbar-test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * Update packages/fluentui/react-northstar/test/specs/components/Toolbar/Toolbar-test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * Update packages/fluentui/react-northstar/test/specs/components/Toolbar/Toolbar-test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * Update packages/fluentui/react-northstar/test/specs/components/Toolbar/Toolbar-test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * fix(Toolbar): fix test Co-authored-by: Oleksandr Fediashov <[email protected]>
#### Pull request checklist - [x] Addresses an existing issue: Fixes #14720 - [ ] Include a change request file using `$ yarn change` #### Description of changes > TreeItems which are parents hide their selection indicators when they are collapsed. This is not coherent with [WCAG guideline 1.3](https://www.w3.org/TR/WCAG20/#content-structure-separation) which states “Create content that can be presented in different ways (for example simpler layout) without losing information or structure”, since summary information for the item (the checkbox in indeterminate or checked state) is removed when the TreeItem is collapsed. There does not appear to be a way to override this behavior. This PR will make the selectable indicator always visible. #### Focus areas to test (optional)
* Moving Rating into react-next for future conversion. * Updating API and changing import for Rating.ButtonControlled.Example.tsx * Change files * Converting Rating.base.tsx to a function component within react-next. * Updating Rating * Adding perf and vr tests for Rating * Change files * Removing a code comment from Rating.test.tsx * Add proper controlled behavior, remove deprecated props, simplify logic * remove copyright header * Test and example updates * fix docs typo Co-authored-by: Elizabeth Craig <[email protected]>
* add a few more vr tests for v7 button * fix
…hem (#14824) * Some of the api fixes. * Change files * Updating v7 imports. * Change files * updates. * Updates. * update. * Change files * Updates to comments. * fixing import. * more * exporting IPoint and Point. * Fixing positioning tests to not be exported. * fixing * Figured it out. * Update change/@fluentui-react-next-2020-09-08-15-51-40-chore-export-imports.json Co-authored-by: Xu Gao <[email protected]> Co-authored-by: Xu Gao <[email protected]>
* Fix issue when we focus on charts in IE * Change files Co-authored-by: Rajesh Goriga <[email protected]>
* Add getMenuItemStyles to ContextualMenu exports * Change files * api update Co-authored-by: Anna Pablo <[email protected]>
* Vertical stacked bar chart combined callout and other tweaks VerticalStackedBarChart - props for custom rendering the callout and choosing between combined and per-point callouts - props for customizing the style or position of the callout - skip outputting bars for zero-value points - remove ref array where indexes were not deterministic * Change files * changing to "major" due to removed exports (internal state interface shouldn't be exported) * maintain earlier update
* chore: refactor E2E tests * fix description * fix slowMo val * fix descriptions * one more fix * refactor pressKey * refactor getPropertyValue * rename methods
#### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes This PR renames the `BreadcrumbExample` to `BreadcrumbExampleBasic` to avoid the warning that is missing some example and fixes the console warning about `children` and `content` conflicting on `BreadcrumbDivider` #### Focus areas to test (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn change
Description of changes
(give an overview)
Focus areas to test
(optional)