Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint TODOs in CalloutContent #14514

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Conversation

MLoughry
Copy link
Contributor

Fixes #14479

Pull request checklist

Description of changes

Fix TODO comments in CalloutContent

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 310df96:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 13, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 934 943 5000
ButtonNext mount 599 614 5000
Checkbox mount 1682 1651 5000
CheckboxBase mount 1375 1345 5000
CheckboxNext mount 1754 1803 5000
ChoiceGroup mount 5216 5276 5000
ComboBox mount 1042 947 1000
CommandBar mount 8009 8041 1000
ContextualMenu mount 14556 14479 1000
DefaultButton mount 1147 1165 5000
DetailsRow mount 3675 3747 5000
DetailsRowFast mount 3644 3691 5000
DetailsRowNoStyles mount 3551 3566 5000
Dialog mount 1580 1523 1000
DocumentCardTitle mount 1953 1908 1000
Dropdown mount 2721 2715 5000
FocusZone mount 1891 1902 5000
IconButton mount 1820 1788 5000
Label mount 364 361 5000
Link mount 481 468 5000
LinkNext mount 510 515 5000
MenuButton mount 1549 1553 5000
Nav mount 3416 3322 1000
Panel mount 1519 1477 1000
Persona mount 887 851 1000
Pivot mount 1477 1482 1000
PivotNext mount 1453 1463 1000
PrimaryButton mount 1341 1299 5000
SearchBox mount 1318 1344 5000
SearchBoxNext mount 1352 1419 5000
Slider mount 1517 1639 5000
SliderNext mount 2105 2055 5000
SpinButton mount 5530 5311 5000
SpinButtonNext mount 5341 5305 5000
Spinner mount 461 443 5000
SplitButton mount 3312 3301 5000
Stack mount 552 555 5000
StackWithIntrinsicChildren mount 2204 2158 5000
StackWithTextChildren mount 5409 5470 5000
TagPicker mount 2900 2987 5000
Text mount 457 433 5000
TextField mount 1450 1483 5000
ThemeProvider mount 2994 3099 5000
ThemeProvider virtual-rerender 500 473 5000
Toggle mount 868 886 5000
ToggleNext mount 882 884 5000
button mount 128 110 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 135 43 3.14:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.53 0.89:1 2000 946
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 609
🔧 Checkbox.Fluent 0.73 0.36 2.03:1 1000 727
🦄 Dialog.Fluent 0.16 0.24 0.67:1 5000 805
🔧 Dropdown.Fluent 3.15 0.5 6.3:1 1000 3154
🔧 Icon.Fluent 0.15 0.05 3:1 5000 730
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 380
🔧 Slider.Fluent 1.74 0.38 4.58:1 1000 1742
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 362
🦄 Tooltip.Fluent 0.11 18.81 0.01:1 5000 556

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssNestingPerf.default 60 45 1.33:1
FlexMinimalPerf.default 326 283 1.15:1
TreeWith60ListItems.default 259 225 1.15:1
TextMinimalPerf.default 363 326 1.11:1
AttachmentMinimalPerf.default 164 149 1.1:1
ButtonMinimalPerf.default 187 172 1.09:1
ButtonUseCssPerf.default 51 47 1.09:1
Text.Fluent 362 336 1.08:1
AccordionMinimalPerf.default 161 150 1.07:1
ImageMinimalPerf.default 390 366 1.07:1
ProviderMinimalPerf.default 1041 977 1.07:1
Checkbox.Fluent 727 679 1.07:1
Tooltip.Fluent 556 519 1.07:1
HeaderSlotsPerf.default 808 763 1.06:1
LabelMinimalPerf.default 419 396 1.06:1
SegmentMinimalPerf.default 352 331 1.06:1
ProviderMergeThemesPerf.default 2073 1966 1.05:1
Avatar.Fluent 946 902 1.05:1
AvatarMinimalPerf.default 495 474 1.04:1
BoxMinimalPerf.default 354 341 1.04:1
DividerMinimalPerf.default 353 338 1.04:1
LayoutMinimalPerf.default 424 406 1.04:1
PopupMinimalPerf.default 721 693 1.04:1
PortalMinimalPerf.default 134 129 1.04:1
TableManyItemsPerf.default 2282 2201 1.04:1
ToolbarMinimalPerf.default 1036 998 1.04:1
ChatDuplicateMessagesPerf.default 453 440 1.03:1
ChatMinimalPerf.default 633 613 1.03:1
EmbedMinimalPerf.default 2034 1979 1.03:1
GridMinimalPerf.default 347 338 1.03:1
ListMinimalPerf.default 486 473 1.03:1
RefMinimalPerf.default 220 214 1.03:1
SkeletonMinimalPerf.default 410 397 1.03:1
StatusMinimalPerf.default 717 694 1.03:1
TooltipMinimalPerf.default 819 799 1.03:1
Image.Fluent 380 368 1.03:1
CardMinimalPerf.default 557 544 1.02:1
CarouselMinimalPerf.default 479 469 1.02:1
ChatWithPopoverPerf.default 493 484 1.02:1
DropdownMinimalPerf.default 3131 3066 1.02:1
ListWith60ListItems.default 1170 1148 1.02:1
CustomToolbarPrototype.default 4110 4036 1.02:1
VideoMinimalPerf.default 650 637 1.02:1
AnimationMinimalPerf.default 407 404 1.01:1
HeaderMinimalPerf.default 367 364 1.01:1
ListNestedPerf.default 927 914 1.01:1
MenuMinimalPerf.default 886 877 1.01:1
ReactionMinimalPerf.default 402 397 1.01:1
SliderMinimalPerf.default 1743 1730 1.01:1
Dialog.Fluent 805 794 1.01:1
Slider.Fluent 1742 1729 1.01:1
AlertMinimalPerf.default 302 303 1:1
CheckboxMinimalPerf.default 2957 2943 1:1
MenuButtonMinimalPerf.default 1588 1589 1:1
SplitButtonMinimalPerf.default 3951 3963 1:1
IconMinimalPerf.default 672 670 1:1
TreeMinimalPerf.default 922 922 1:1
Button.Fluent 609 606 1:1
AttachmentSlotsPerf.default 1178 1188 0.99:1
ButtonSlotsPerf.default 627 632 0.99:1
DropdownManyItemsPerf.default 776 784 0.99:1
FormMinimalPerf.default 396 399 0.99:1
InputMinimalPerf.default 1365 1385 0.99:1
ItemLayoutMinimalPerf.default 1281 1297 0.99:1
LoaderMinimalPerf.default 776 781 0.99:1
Dropdown.Fluent 3154 3198 0.99:1
DialogMinimalPerf.default 816 835 0.98:1
TableMinimalPerf.default 425 434 0.98:1
TextAreaMinimalPerf.default 469 481 0.98:1
Icon.Fluent 730 755 0.97:1
ListCommonPerf.default 956 999 0.96:1
RadioGroupMinimalPerf.default 433 450 0.96:1

@size-auditor
Copy link

size-auditor bot commented Aug 14, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-next-SelectedItemsList 267.956 kB 268.041 kB ExceedsBaseline     85 bytes
office-ui-fabric-react fluentui-react-next-ContextualMenu 145.559 kB 145.644 kB ExceedsBaseline     85 bytes
office-ui-fabric-react fluentui-react-next-Callout 78.423 kB 78.508 kB ExceedsBaseline     85 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 2b472d68367442569f6ebf793ae4d15fdc76f8ac (build)

@MLoughry MLoughry requested a review from ecraig12345 August 14, 2020 18:13
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ecraig12345 ecraig12345 merged commit 5c64f92 into microsoft:master Aug 14, 2020
levithomason pushed a commit to levithomason/fluentui that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CalloutContent: fix eslint-plugin-react-hooks TODOs
4 participants