Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalloutContent: fix eslint-plugin-react-hooks TODOs #14479

Closed
ecraig12345 opened this issue Aug 12, 2020 · 0 comments · Fixed by #14514
Closed

CalloutContent: fix eslint-plugin-react-hooks TODOs #14479

ecraig12345 opened this issue Aug 12, 2020 · 0 comments · Fixed by #14514
Assignees

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Aug 12, 2020

#14478 enables eslint-plugin-react-hooks for react-next. There were a bunch of issues in CalloutContent which I wasn't quite sure how to handle. Since I'd like to get this in ASAP and Michael is OOF, for the time being I left TODO comments noting the issues and disabled the rule for those lines.

Before release these issues should be fixed properly: either add the missing hook deps (or related code changes), or add notes about why the rule is disabled and remove the TODO.

(There's also this TODO in FabricBase.)

MLoughry added a commit to MLoughry/office-ui-fabric-react that referenced this issue Aug 13, 2020
@msft-github-bot msft-github-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Aug 14, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants