Enable eslint-plugin-react-hooks for react-next #14478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
dzearing,
joschect,
khmakoto,
micahgodbolt and
xugao
as code owners
This was referenced Aug 12, 2020
ecraig12345
commented
Aug 12, 2020
| * The left position of the beak | ||
| */ | ||
| const [beakLeft, setBeakLeft] = React.useState<string>(); | ||
| return React.useMemo(() => { |
There was a problem hiding this comment.
The parts of the beak position will never change independently, so this is a much more efficient way to calculate and update them.
| }); | ||
| timeoutIds.splice(0, timeoutIds.length); // clear array |
There was a problem hiding this comment.
Without this, the array of timeouts keeps unnecessarily growing (and each one is unnecessarily cleared again) with every resize event
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98de017:
|
xugao
reviewed
Aug 12, 2020
xugao
reviewed
Aug 12, 2020
xugao
reviewed
Aug 12, 2020
packages/react-next/src/components/Coachmark/Coachmark.base.tsx
Outdated
Show resolved
Hide resolved
ecraig12345
force-pushed
the
eslint-hooks-next
branch
from
0b9279a to
d16d6ba
Compare
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
xugao
approved these changes
Aug 12, 2020
Asset size changes
Baseline commit: e34570d86cd27872c5b76c06022757afbaf22707 (build) |
|
🎉 Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Enable
eslint-plugin-react-hooksfor react-next to help catch hook-related mistakes, and fix existing issues. Also add a rule to our eslint config to help catch accidental usage of DOM globals (such asfocus()which was accidentally used in SearchBox).In the interest of getting this merged more quickly, I temporarily disabled the rule in a bunch of places for CalloutContent and SpinButton and will make follow-up issues to fix this.
Also started making some updates to the release notes breaking changes to alphabetize components and add a couple missing things (or notes about components to look over later).