Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uifabric/example-app-base: Updating dependencies to resolve security issues #14543

Merged
merged 4 commits into from
Aug 17, 2020
Merged

@uifabric/example-app-base: Updating dependencies to resolve security issues #14543

merged 4 commits into from
Aug 17, 2020

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Aug 14, 2020 •
edited
Loading

Pull request checklist

Description of changes

#14453 indicated that there were people hitting component governance alerts due to security issues of 2 dependencies in @uifabric/example-app-base and @uifabric/tsx-editor. This PR upgrades those dependencies and fixes issues that this caused regarding changed paths.

Focus areas to test

Tested that doing yarn start on example-app-base, tsx-editor and fabric-website still works as expected.

@khmakoto khmakoto requested a review from ecraig12345 August 14, 2020 22:08
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 14, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 361afcb:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 14, 2020 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 2ff5da6

Possible causes

  • The baseline build 2ff5da6 is broken
  • The Size Auditor run for the baseline build 2ff5da6 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 939 921 5000
ButtonNext mount 603 603 5000
Checkbox mount 1664 1627 5000
CheckboxBase mount 1382 1360 5000
CheckboxNext mount 1727 1782 5000
ChoiceGroup mount 5208 5082 5000
ComboBox mount 968 953 1000
CommandBar mount 8057 8044 1000
ContextualMenu mount 15783 15299 1000
DefaultButton mount 1153 1145 5000
DetailsRow mount 3660 3557 5000
DetailsRowFast mount 3583 3689 5000
DetailsRowNoStyles mount 3452 3505 5000
Dialog mount 1494 1529 1000
DocumentCardTitle mount 1905 1842 1000
Dropdown mount 2645 2666 5000
FocusZone mount 1826 1868 5000
IconButton mount 1775 1787 5000
Label mount 361 360 5000
Link mount 460 477 5000
LinkNext mount 490 508 5000
MenuButton mount 1492 1509 5000
Nav mount 3288 3310 1000
Panel mount 1502 1436 1000
Persona mount 860 842 1000
Pivot mount 1418 1450 1000
PivotNext mount 1446 1430 1000
PrimaryButton mount 1285 1297 5000
SearchBox mount 1294 1316 5000
SearchBoxNext mount 1338 1376 5000
Slider mount 1521 1506 5000
SliderNext mount 1980 1928 5000
SpinButton mount 4979 5004 5000
SpinButtonNext mount 5180 5052 5000
Spinner mount 434 450 5000
SplitButton mount 3252 3192 5000
Stack mount 522 531 5000
StackWithIntrinsicChildren mount 2102 2060 5000
StackWithTextChildren mount 5152 5126 5000
TagPicker mount 2757 2845 5000
Text mount 433 417 5000
TextField mount 1387 1438 5000
ThemeProvider mount 3046 2915 5000
ThemeProvider virtual-rerender 473 485 5000
Toggle mount 868 840 5000
ToggleNext mount 846 823 5000
button mount 122 122 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 135 50 2.7:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.49 0.9:1 2000 881
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 530
🔧 Checkbox.Fluent 0.64 0.33 1.94:1 1000 641
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 791
🔧 Dropdown.Fluent 3.11 0.49 6.35:1 1000 3108
🔧 Icon.Fluent 0.15 0.05 3:1 5000 732
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 385
🔧 Slider.Fluent 1.68 0.37 4.54:1 1000 1678
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 338
🦄 Tooltip.Fluent 0.11 18.92 0.01:1 5000 534

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssNestingPerf.default 57 44 1.3:1
PortalMinimalPerf.default 150 119 1.26:1
ButtonUseCssPerf.default 55 44 1.25:1
AttachmentMinimalPerf.default 182 150 1.21:1
FlexMinimalPerf.default 284 249 1.14:1
RefMinimalPerf.default 238 210 1.13:1
TableManyItemsPerf.default 2306 2120 1.09:1
CarouselMinimalPerf.default 481 447 1.08:1
TableMinimalPerf.default 403 372 1.08:1
ButtonMinimalPerf.default 186 174 1.07:1
VideoMinimalPerf.default 617 574 1.07:1
BoxMinimalPerf.default 354 334 1.06:1
ChatMinimalPerf.default 624 589 1.06:1
ToolbarMinimalPerf.default 944 889 1.06:1
Image.Fluent 385 362 1.06:1
AttachmentSlotsPerf.default 1209 1153 1.05:1
DividerMinimalPerf.default 370 353 1.05:1
ListMinimalPerf.default 477 455 1.05:1
TreeWith60ListItems.default 220 210 1.05:1
Icon.Fluent 732 697 1.05:1
CardMinimalPerf.default 572 550 1.04:1
ListWith60ListItems.default 1145 1099 1.04:1
MenuMinimalPerf.default 868 837 1.04:1
Tooltip.Fluent 534 513 1.04:1
AlertMinimalPerf.default 304 294 1.03:1
ProviderMergeThemesPerf.default 2048 1996 1.03:1
ProviderMinimalPerf.default 996 970 1.03:1
SliderMinimalPerf.default 1732 1683 1.03:1
CustomToolbarPrototype.default 3888 3777 1.03:1
HeaderSlotsPerf.default 747 732 1.02:1
LayoutMinimalPerf.default 392 385 1.02:1
SkeletonMinimalPerf.default 401 393 1.02:1
Button.Fluent 530 521 1.02:1
Text.Fluent 338 331 1.02:1
AccordionMinimalPerf.default 160 158 1.01:1
ChatWithPopoverPerf.default 487 484 1.01:1
DropdownMinimalPerf.default 3001 2982 1.01:1
EmbedMinimalPerf.default 1905 1880 1.01:1
HeaderMinimalPerf.default 334 330 1.01:1
ItemLayoutMinimalPerf.default 1266 1250 1.01:1
ListCommonPerf.default 934 922 1.01:1
ListNestedPerf.default 876 867 1.01:1
LoaderMinimalPerf.default 759 753 1.01:1
RadioGroupMinimalPerf.default 408 405 1.01:1
IconMinimalPerf.default 682 678 1.01:1
TextAreaMinimalPerf.default 453 448 1.01:1
Dialog.Fluent 791 782 1.01:1
Dropdown.Fluent 3108 3070 1.01:1
Slider.Fluent 1678 1665 1.01:1
AvatarMinimalPerf.default 480 479 1:1
ButtonSlotsPerf.default 604 607 1:1
CheckboxMinimalPerf.default 2883 2875 1:1
DialogMinimalPerf.default 788 786 1:1
InputMinimalPerf.default 1325 1319 1:1
LabelMinimalPerf.default 393 392 1:1
MenuButtonMinimalPerf.default 1550 1548 1:1
PopupMinimalPerf.default 688 688 1:1
SegmentMinimalPerf.default 342 341 1:1
SplitButtonMinimalPerf.default 3894 3878 1:1
Avatar.Fluent 881 879 1:1
AnimationMinimalPerf.default 394 400 0.99:1
DropdownManyItemsPerf.default 756 760 0.99:1
GridMinimalPerf.default 324 326 0.99:1
StatusMinimalPerf.default 678 688 0.99:1
TooltipMinimalPerf.default 792 797 0.99:1
Checkbox.Fluent 641 645 0.99:1
ChatDuplicateMessagesPerf.default 430 441 0.98:1
FormMinimalPerf.default 377 387 0.97:1
ImageMinimalPerf.default 347 358 0.97:1
TreeMinimalPerf.default 852 877 0.97:1
TextMinimalPerf.default 330 345 0.96:1
ReactionMinimalPerf.default 412 432 0.95:1

ecraig12345
ecraig12345 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ecraig12345 ecraig12345 merged commit 0620a0d into microsoft:master Aug 17, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Aug 18, 2020
Closed
levithomason pushed a commit to levithomason/fluentui that referenced this pull request Aug 24, 2020
@khmakoto @levithomason
@uifabric/example-app-base: Updating dependencies to resolve security…
1a66744 
… issues (microsoft#14543)
@khmakoto khmakoto deleted the exampleAppBaseDeps branch April 7, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@christiango christiango christiango approved these changes

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security issues with prism and markdown-to-jsx dependencies in @uifabric/example-app-base
4 participants
@khmakoto @msft-github-bot @christiango @ecraig12345