Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackItem does not use its padding token #12592

Closed
louiebert opened this issue Apr 7, 2020 · 3 comments · Fixed by #14554
Closed

StackItem does not use its padding token #12592

louiebert opened this issue Apr 7, 2020 · 3 comments · Fixed by #14554
Assignees
Labels

Comments

@louiebert
Copy link

Environment Information

  • Package version(s): office-ui-fabric-react v7.105.11

Please provide a reproduction of the bug in a codepen:

https://codepen.io/louiebert/pen/zYvOvKK

Actual behavior:

StackItem does not render its padding provided in tokens prop.

Expected behavior:

StackItem does render its padding provided in tokens prop.

Priorities and help requested:

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Likely fix

Add a new line for padding just below margin in StackItem.styles.ts:23

@joschect
Copy link
Contributor

joschect commented Apr 7, 2020

@louiebert Thanks for submitting this as an issue and including that codepen. This is definitely reproducible and is a bug. We'll get this fixed!

@stratospheres
Copy link

@joschect - any update on this? We might have a workaround, but it's fairly ugly. We'd love to get this fix...

msft-github-bot pushed a commit that referenced this issue Aug 17, 2020
#### Pull request checklist

- [x] Addresses an existing issue: Fixes #12592
- [x] Include a change request file using `$ yarn change`

#### Description of changes

StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed.

#### Focus areas to test

(optional)
@msft-github-bot msft-github-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Aug 17, 2020
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14554, which has now been successfully released as [email protected].:tada:

Handy links:

levithomason pushed a commit to levithomason/fluentui that referenced this issue Aug 24, 2020
…ken (microsoft#14554)

#### Pull request checklist

- [x] Addresses an existing issue: Fixes microsoft#12592
- [x] Include a change request file using `$ yarn change`

#### Description of changes

StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed.

#### Focus areas to test

(optional)
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants