-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackItem does not use its padding
token
#12592
Labels
Comments
@louiebert Thanks for submitting this as an issue and including that codepen. This is definitely reproducible and is a bug. We'll get this fixed! |
@joschect - any update on this? We might have a workaround, but it's fairly ugly. We'd love to get this fix... |
2 tasks
msft-github-bot
pushed a commit
that referenced
this issue
Aug 17, 2020
#### Pull request checklist - [x] Addresses an existing issue: Fixes #12592 - [x] Include a change request file using `$ yarn change` #### Description of changes StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed. #### Focus areas to test (optional)
🎉This issue was addressed in #14554, which has now been successfully released as Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this issue
Aug 24, 2020
…ken (microsoft#14554) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#12592 - [x] Include a change request file using `$ yarn change` #### Description of changes StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed. #### Focus areas to test (optional)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Environment Information
Please provide a reproduction of the bug in a codepen:
https://codepen.io/louiebert/pen/zYvOvKK
Actual behavior:
StackItem does not render its padding provided in
tokens
prop.Expected behavior:
StackItem does render its padding provided in
tokens
prop.Priorities and help requested:
Are you willing to submit a PR to fix? Yes
Requested priority: Normal
Likely fix
Add a new line for
padding
just belowmargin
in StackItem.styles.ts:23The text was updated successfully, but these errors were encountered: