Fixing issue #12592- StackItem does not use its padding token
#14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 497acb3:
|
dzearing
approved these changes
Aug 17, 2020
|
Resetting build. |
Asset size changes
Baseline commit: 0780384fb2ea7bffcad8d51df0ca8aaa7e19be9c (build) |
khmakoto
approved these changes
Aug 17, 2020
|
@msft-github-bot merge in 1 minute. |
|
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
🎉 Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Aug 24, 2020
…ken (microsoft#14554) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#12592 - [x] Include a change request file using `$ yarn change` #### Description of changes StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed. #### Focus areas to test (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
paddingtoken #12592$ yarn changeDescription of changes
StackItem styles has a 'padding' token but it is not used in the code. so adding that to fix and function as designed.
Focus areas to test
(optional)