Staging the react-avatar package; #14518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/avatar # Conflicts: # yarn.lock
…eat/avatar # Conflicts: # apps/test-bundles/package.json # packages/fluentui/react-northstar/src/components/Provider/Provider.tsx # yarn.lock
…eat/avatar # Conflicts: # apps/test-bundles/package.json
feat: use react-compose in react-avatar
…eat/avatar # Conflicts: # yarn.lock
…eat/avatar # Conflicts: # .vscode/settings.json # packages/fluentui/react-northstar/src/utils/felaStylisEnhancer.ts # packages/react-compose/etc/react-compose.api.md # packages/react-compose/package.json # packages/react-compose/src/compose.ts # packages/react-compose/src/types.ts # packages/react-compose/src/utils.ts # scripts/package.json # yarn.lock
…eat/avatar # Conflicts: # packages/react-compose/src/next/types.ts
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0b8902:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 07e38ab3f989e8ea69cab0c880950c8027204eec (build) |
behowell
approved these changes
Aug 15, 2020
behowell
approved these changes
Aug 15, 2020
yarn.lock
Outdated
| @@ -116,6 +116,28 @@ | |||
| invariant "^2.2.4" | |||
| semver "^5.5.0" | |||
|
|
|||
| "@babel/[email protected]": | |||
There was a problem hiding this comment.
Are all of these yarn.lock changes intended? Or do you need to update dependency versions in package.json?
…eat/avatar # Conflicts: # yarn.lock
|
🎉 Handy links: |
|
🎉 Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Aug 24, 2020
* Adding react-avatar. * Adding Avatar. * Updating Avatar to use raw sass. * blah. * more updates. * Changes. * Shorthand props now work * more updates. * Adding PersonaCoin example. * Cleanup. * Updating url. * changes * more changes. * Adding button. Renaming handledProp to mappedProp. * Addressing missing font definitions. Adding stylesheet support to themeprovider. * Addressing review feedback. * Merge branch 'master' of https://github.com/microsoft/fluentui into feat/avatar # Conflicts: # apps/test-bundles/package.json # packages/fluentui/react-northstar/src/components/Provider/Provider.tsx # yarn.lock * Undoing changes. * undoing a few more changes. * Updating react-compose dependency * Fixing broken things. * wip * Update packages/react-compose/src/utils.ts * converted all components to use react-compose * wip * Integrating useStylesheet. * Removing dupe stylesheets provider. * Merge branch 'master' of https://github.com/microsoft/fluentui into feat/avatar # Conflicts: # .vscode/settings.json # packages/fluentui/react-northstar/src/utils/felaStylisEnhancer.ts # packages/react-compose/etc/react-compose.api.md # packages/react-compose/package.json # packages/react-compose/src/compose.ts # packages/react-compose/src/types.ts # packages/react-compose/src/utils.ts # scripts/package.json # yarn.lock * updated readme * Change files * removing private * Change files * fixing lint. * Ensuring tests work. * Awesome. * updates. * yarn updates. Co-authored-by: Marija Najdova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this up and running to unblock @behowell .
This will include the converged
Avatar. We may need to separate out a separate react-badge package as well, separately of this PR.Note; this has a converted Image, but really we should change this asap to
react-image.