Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing lint error that's breaking master build due to mismatched package versions. #14565

Merged
merged 4 commits into from
Aug 17, 2020
Merged

Fixing lint error that's breaking master build due to mismatched package versions. #14565

merged 4 commits into from
Aug 17, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Master build is broken because of mismatched package versions. This PR fixes it.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 96a64f5:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 17, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 995 987 5000
ButtonNext mount 635 613 5000
Checkbox mount 1727 1809 5000
CheckboxBase mount 1450 1483 5000
CheckboxNext mount 1870 1899 5000
ChoiceGroup mount 5512 5544 5000
ComboBox mount 1050 1075 1000
CommandBar mount 8572 8625 1000
ContextualMenu mount 16915 16766 1000
DefaultButton mount 1245 1239 5000
DetailsRow mount 4011 4052 5000
DetailsRowFast mount 4021 4081 5000
DetailsRowNoStyles mount 3829 3815 5000
Dialog mount 1751 1706 1000
DocumentCardTitle mount 2010 2028 1000
Dropdown mount 2956 2920 5000
FocusZone mount 1939 2003 5000
IconButton mount 1926 1987 5000
Label mount 378 370 5000
Link mount 474 487 5000
LinkNext mount 541 521 5000
MenuButton mount 1628 1641 5000
Nav mount 3662 3566 1000
Panel mount 1604 1666 1000
Persona mount 938 969 1000
Pivot mount 1655 1595 1000
PivotNext mount 1621 1571 1000
PrimaryButton mount 1348 1420 5000
SearchBox mount 1503 1468 5000
SearchBoxNext mount 1464 1468 5000
Slider mount 1687 1677 5000
SliderNext mount 2140 2130 5000
SpinButton mount 5731 5648 5000
SpinButtonNext mount 5771 5757 5000
Spinner mount 460 477 5000
SplitButton mount 3506 3549 5000
Stack mount 561 560 5000
StackWithIntrinsicChildren mount 2234 2219 5000
StackWithTextChildren mount 5444 5483 5000
TagPicker mount 3168 3192 5000
Text mount 451 452 5000
TextField mount 1543 1518 5000
ThemeProvider mount 3359 3349 5000
ThemeProvider virtual-rerender 490 472 5000
Toggle mount 933 896 5000
ToggleNext mount 909 922 5000
button mount 134 138 5000

Perf Analysis (Fluent)

⚠️ 4 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 140 49 2.86:1 analysis
ButtonUseCssPerf.default 62 50 1.24:1 analysis
ButtonUseCssNestingPerf.default 62 53 1.17:1 analysis
ListCommonPerf.default 765 1072 0.71:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.49 0.52 0.94:1 2000 978
🦄 Button.Fluent 0.12 0.22 0.55:1 5000 590
🔧 Checkbox.Fluent 0.71 0.36 1.97:1 1000 706
🦄 Dialog.Fluent 0.16 0.24 0.67:1 5000 819
🔧 Dropdown.Fluent 3.32 0.51 6.51:1 1000 3321
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 758
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 397
🔧 Slider.Fluent 1.87 0.42 4.45:1 1000 1873
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 374
🦄 Tooltip.Fluent 0.12 21.65 0.01:1 5000 588

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 203 180 1.13:1
FlexMinimalPerf.default 310 276 1.12:1
PortalMinimalPerf.default 155 138 1.12:1
ListMinimalPerf.default 528 475 1.11:1
Text.Fluent 374 341 1.1:1
RefMinimalPerf.default 248 227 1.09:1
AnimationMinimalPerf.default 444 415 1.07:1
GridMinimalPerf.default 370 345 1.07:1
LabelMinimalPerf.default 449 420 1.07:1
ReactionMinimalPerf.default 427 399 1.07:1
Image.Fluent 397 371 1.07:1
AccordionMinimalPerf.default 164 154 1.06:1
AvatarMinimalPerf.default 549 517 1.06:1
PopupMinimalPerf.default 760 715 1.06:1
ProviderMinimalPerf.default 1136 1074 1.06:1
TextMinimalPerf.default 381 360 1.06:1
Icon.Fluent 758 713 1.06:1
AttachmentMinimalPerf.default 178 170 1.05:1
AttachmentSlotsPerf.default 1330 1271 1.05:1
ChatDuplicateMessagesPerf.default 490 466 1.05:1
ChatWithPopoverPerf.default 546 522 1.05:1
LayoutMinimalPerf.default 441 419 1.05:1
ProviderMergeThemesPerf.default 2182 2087 1.05:1
Button.Fluent 590 561 1.05:1
BoxMinimalPerf.default 381 366 1.04:1
CardMinimalPerf.default 597 575 1.04:1
CarouselMinimalPerf.default 526 505 1.04:1
HeaderMinimalPerf.default 386 370 1.04:1
HeaderSlotsPerf.default 845 813 1.04:1
ImageMinimalPerf.default 391 376 1.04:1
ItemLayoutMinimalPerf.default 1437 1386 1.04:1
StatusMinimalPerf.default 748 721 1.04:1
MenuMinimalPerf.default 953 924 1.03:1
SplitButtonMinimalPerf.default 4362 4251 1.03:1
TableMinimalPerf.default 425 411 1.03:1
TooltipMinimalPerf.default 864 841 1.03:1
Slider.Fluent 1873 1822 1.03:1
CheckboxMinimalPerf.default 3251 3199 1.02:1
DialogMinimalPerf.default 834 818 1.02:1
DividerMinimalPerf.default 375 366 1.02:1
DropdownManyItemsPerf.default 846 832 1.02:1
MenuButtonMinimalPerf.default 1733 1700 1.02:1
RadioGroupMinimalPerf.default 441 431 1.02:1
TableManyItemsPerf.default 2453 2413 1.02:1
CustomToolbarPrototype.default 4409 4305 1.02:1
ButtonSlotsPerf.default 677 672 1.01:1
ChatMinimalPerf.default 632 626 1.01:1
EmbedMinimalPerf.default 2158 2135 1.01:1
InputMinimalPerf.default 1523 1506 1.01:1
SegmentMinimalPerf.default 367 365 1.01:1
ToolbarMinimalPerf.default 1043 1030 1.01:1
Avatar.Fluent 978 971 1.01:1
Tooltip.Fluent 588 581 1.01:1
DropdownMinimalPerf.default 3377 3378 1:1
FormMinimalPerf.default 428 426 1:1
SkeletonMinimalPerf.default 423 422 1:1
TreeMinimalPerf.default 958 956 1:1
Dialog.Fluent 819 817 1:1
SliderMinimalPerf.default 1866 1876 0.99:1
Checkbox.Fluent 706 715 0.99:1
Dropdown.Fluent 3321 3359 0.99:1
LoaderMinimalPerf.default 813 830 0.98:1
IconMinimalPerf.default 717 730 0.98:1
TextAreaMinimalPerf.default 499 508 0.98:1
TreeWith60ListItems.default 242 247 0.98:1
AlertMinimalPerf.default 324 333 0.97:1
VideoMinimalPerf.default 675 702 0.96:1
ListWith60ListItems.default 1064 1239 0.86:1
ListNestedPerf.default 652 966 0.67:1

@size-auditor
Copy link

size-auditor bot commented Aug 17, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb0183ea569b621349fe8e1daefdd42440f560f5 (build)

@kenotron kenotron merged commit f550420 into microsoft:master Aug 17, 2020
@khmakoto khmakoto deleted the mismatchedVersions branch August 17, 2020 20:03
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

levithomason pushed a commit to levithomason/fluentui that referenced this pull request Aug 24, 2020
@khmakoto @levithomason
Fixing lint error that's breaking master build due to mismatched pack…
5407026 
…age versions. (microsoft#14565)

* Fixing lint error that's breaking master build due to mismatched package versions.

* Change files

* Adding @uifabric/icons to package.json.

* Adding @fluentui/storybook dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenotron kenotron kenotron approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khmakoto @msft-github-bot @kenotron