lowercase filetypeicons #14569
Merged
lowercase filetypeicons #14569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are lowercase. SVGs for 20_1.5x are now available.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 00ee9a2:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 160f6141e0bf41a118d71cac0744fd6282333f86 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
dmichon-msft
approved these changes
Aug 17, 2020
|
Yeah, I think you’re right. I’m waiting for that one to deploy, I have the 1-line rev for Fabric ready to go.
|
dzearing
approved these changes
Aug 17, 2020
|
whoops; merged too soon. Talking with @bigbadcapers if I should revert, sounds like not |
|
Ive been testing and it looks like the …004 version isn’t deploying as quickly as the previous one. I think it’s okay to let Fabric deploy with the ….003 version since that fixes the issue and I will check tomorrow if I need to make another PR to make sure Fabric is pointing to the very latest (which adds a second layer of safeguard to prevent this issue from reoccurring).
|
|
🎉 Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Aug 24, 2020
* Updating to use latest iconset from latest versioned CDN. All filetypes are lowercase. SVGs for 20_1.5x are now available. * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
References the filetype CDN version that has all lowercase filenames. Removes restriction on using 20_1.5x SVG sizes since they are now available.
Focus areas to test
Experiments -> File Type Icons