Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export getMenuStyles from ContextualMenu #14963

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Export getMenuStyles from ContextualMenu #14963

merged 3 commits into from
Sep 10, 2020

Conversation

apneer
Copy link
Contributor

@apneer apneer commented Sep 9, 2020 •
edited by xugao
Loading

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Export getMenuStyles from ContextualMenu to avoid needing to use deep import path

@apneer apneer requested a review from joschect as a code owner September 9, 2020 23:06
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit affbb5a:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 9, 2020 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-ContextualMenu 150.247 kB 150.298 kB ExceedsBaseline     51 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: a857ac9761acc140c6d04b1645950896f61af8af (build)

@xugao xugao changed the title Anpablo/fluentuxexport Export getMenuStyles from ContextualMenu Sep 10, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 929 931 5000
ButtonNext mount 728 718 5000
Checkbox mount 1641 1594 5000
CheckboxBase mount 1334 1325 5000
CheckboxNext mount 1587 1533 5000
ChoiceGroup mount 5118 4995 5000
ChoiceGroupNext mount 5099 5138 5000
ComboBox mount 959 917 1000
CommandBar mount 7626 7450 1000
ContextualMenu mount 12368 12557 1000
DefaultButton mount 1132 1151 5000
DetailsRow mount 3665 3676 5000
DetailsRowFast mount 3703 3636 5000
DetailsRowNoStyles mount 3391 3404 5000
Dialog mount 1518 1475 1000
DocumentCardTitle mount 1799 1811 1000
Dropdown mount 2646 2698 5000
FocusZone mount 1814 1800 5000
IconButton mount 1788 1823 5000
Label mount 350 337 5000
Link mount 470 442 5000
LinkNext mount 470 470 5000
MenuButton mount 1516 1475 5000
MessageBar mount 2058 2044 5000
MessageBarNext mount 2069 2083 5000
Nav mount 3334 3349 1000
OverflowSet mount 1440 1428 5000
OverflowSetNext mount 1056 1058 5000
Panel mount 1447 1460 1000
Persona mount 854 841 1000
Pivot mount 1437 1453 1000
PivotNext mount 1400 1394 1000
PrimaryButton mount 1337 1269 5000
Rating mount 7985 7906 5000
RatingNext mount 7982 7929 5000
SearchBox mount 1365 1327 5000
SearchBoxNext mount 1373 1372 5000
Shimmer mount 2610 2638 5000
ShimmerNext mount 2655 2580 5000
Slider mount 1551 1525 5000
SliderNext mount 2008 1938 5000
SpinButton mount 5136 5047 5000
SpinButtonNext mount 5168 5250 5000
Spinner mount 434 425 5000
SplitButton mount 3231 3229 5000
Stack mount 546 541 5000
StackWithIntrinsicChildren mount 2129 2078 5000
StackWithTextChildren mount 5355 5248 5000
SwatchColorPicker mount 10661 11431 5000
SwatchColorPickerNext mount 10323 10372 5000
TagPicker mount 2902 2756 5000
TeachingBubble mount 48914 49363 5000
TeachingBubbleNext mount 48999 50971 5000
Text mount 449 439 5000
TextField mount 1424 1429 5000
ThemeProvider mount 4391 4385 5000
ThemeProvider virtual-rerender 445 449 5000
Toggle mount 863 856 5000
ToggleNext mount 823 832 5000
button mount 110 119 5000

Perf Analysis (Fluent)

⚠️ 4 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1750 48 36.46:1 analysis
ButtonUseCssNestingPerf.default 1134 48 23.63:1 analysis
ButtonUseCssPerf.default 872 45 19.38:1 analysis
ChatWithPopoverPerf.default 513 483 1.06:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.51 0.94:1 2000 960
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 638
🔧 Checkbox.Fluent 0.65 0.38 1.71:1 1000 647
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 840
🔧 Dropdown.Fluent 2.92 0.49 5.96:1 1000 2919
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 747
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 424
🔧 Slider.Fluent 1.56 0.38 4.11:1 1000 1556
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 412
🦄 Tooltip.Fluent 0.12 14.95 0.01:1 5000 579

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 166 117 1.42:1
RefMinimalPerf.default 255 192 1.33:1
TableMinimalPerf.default 481 379 1.27:1
GridMinimalPerf.default 413 329 1.26:1
BoxMinimalPerf.default 412 340 1.21:1
FlexMinimalPerf.default 349 289 1.21:1
Text.Fluent 412 342 1.2:1
DividerMinimalPerf.default 427 361 1.18:1
HeaderMinimalPerf.default 426 360 1.18:1
SegmentMinimalPerf.default 416 353 1.18:1
TextMinimalPerf.default 413 351 1.18:1
AccordionMinimalPerf.default 174 149 1.17:1
AttachmentMinimalPerf.default 182 157 1.16:1
LayoutMinimalPerf.default 469 405 1.16:1
StatusMinimalPerf.default 817 706 1.16:1
Image.Fluent 424 367 1.16:1
ImageMinimalPerf.default 432 375 1.15:1
TextAreaMinimalPerf.default 558 484 1.15:1
RadioGroupMinimalPerf.default 489 428 1.14:1
SkeletonMinimalPerf.default 459 403 1.14:1
Tooltip.Fluent 579 509 1.14:1
AnimationMinimalPerf.default 433 384 1.13:1
CardMinimalPerf.default 652 578 1.13:1
FormMinimalPerf.default 489 432 1.13:1
ButtonMinimalPerf.default 205 183 1.12:1
TreeWith60ListItems.default 231 209 1.11:1
DialogMinimalPerf.default 856 776 1.1:1
LabelMinimalPerf.default 468 424 1.1:1
IconMinimalPerf.default 766 699 1.1:1
Dialog.Fluent 840 762 1.1:1
AlertMinimalPerf.default 327 299 1.09:1
CarouselMinimalPerf.default 500 459 1.09:1
ChatMinimalPerf.default 688 631 1.09:1
VideoMinimalPerf.default 701 643 1.09:1
AvatarMinimalPerf.default 521 482 1.08:1
ReactionMinimalPerf.default 441 409 1.08:1
TooltipMinimalPerf.default 846 781 1.08:1
MenuMinimalPerf.default 923 866 1.07:1
PopupMinimalPerf.default 728 680 1.07:1
Button.Fluent 638 594 1.07:1
AttachmentSlotsPerf.default 1198 1125 1.06:1
ItemLayoutMinimalPerf.default 1406 1330 1.06:1
ProviderMinimalPerf.default 973 915 1.06:1
Avatar.Fluent 960 909 1.06:1
ChatDuplicateMessagesPerf.default 455 433 1.05:1
HeaderSlotsPerf.default 846 809 1.05:1
MenuButtonMinimalPerf.default 1650 1573 1.05:1
ToolbarMinimalPerf.default 1001 951 1.05:1
TreeMinimalPerf.default 938 896 1.05:1
DropdownManyItemsPerf.default 816 783 1.04:1
EmbedMinimalPerf.default 2016 1935 1.04:1
ProviderMergeThemesPerf.default 1921 1841 1.04:1
SplitButtonMinimalPerf.default 4029 3889 1.04:1
CustomToolbarPrototype.default 3871 3739 1.04:1
CheckboxMinimalPerf.default 2979 2881 1.03:1
Checkbox.Fluent 647 626 1.03:1
Icon.Fluent 747 722 1.03:1
ListMinimalPerf.default 510 500 1.02:1
SliderMinimalPerf.default 1616 1586 1.02:1
TableManyItemsPerf.default 2410 2370 1.02:1
LoaderMinimalPerf.default 755 745 1.01:1
Dropdown.Fluent 2919 2892 1.01:1
ButtonSlotsPerf.default 655 657 1:1
DropdownMinimalPerf.default 2910 2915 1:1
InputMinimalPerf.default 1342 1336 1:1
Slider.Fluent 1556 1588 0.98:1
ListWith60ListItems.default 977 1122 0.87:1
ListCommonPerf.default 729 968 0.75:1
ListNestedPerf.default 646 924 0.7:1

@xugao xugao merged commit 770f5bf into master Sep 10, 2020
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

hutchcodes pushed a commit to hutchcodes/fluentui that referenced this pull request Sep 10, 2020
@apneer @anpablo @hutchcodes
Export getMenuStyles from ContextualMenu (microsoft#14963)
6bf518a 
* Add getMenuItemStyles to ContextualMenu exports

* Change files

* api update

Co-authored-by: Anna Pablo <[email protected]>
@xugao xugao mentioned this pull request Oct 17, 2020
Merged
2 tasks
@ecraig12345 ecraig12345 deleted the anpablo/fluentuxexport branch October 28, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xugao xugao xugao approved these changes

@joschect joschect Awaiting requested review from joschect

Assignees
No one assigned
Labels
Component: ContextualMenu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apneer @msft-github-bot @xugao @anpablo