Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement compound button #14671

Closed
JustSlone opened this issue Aug 21, 2020 · 3 comments · Fixed by #14855
Closed

Implement compound button #14671

JustSlone opened this issue Aug 21, 2020 · 3 comments · Fixed by #14855
Assignees
@khmakoto
Labels
Component: Button Status: Fixed Fixed in some PR
Milestone
v8: Pre-snap

Comments

@JustSlone
Copy link
Collaborator

JustSlone commented Aug 21, 2020 •
edited by khmakoto
Loading

Implement Compound button following details from design spec and theming from current v7 theme.
@JustSlone JustSlone added this to the Version 8: Pre-snap milestone Aug 21, 2020
@JustSlone
Copy link
Collaborator Author

@khmakoto can you fill in any relevant details in this issue too?

@khmakoto khmakoto mentioned this issue Sep 2, 2020
Merged
2 tasks
msft-github-bot pushed a commit that referenced this issue Sep 9, 2020
@khmakoto
CompoundButton: Adding initial component to react-button package (#14855
0d0c48f 
)

#### Pull request checklist

- [x] Addresses an existing issue: Fixes #14671
- [x] Include a change request file using `$ yarn change`

#### Description of changes

This PR adds an implementation for the `CompoundButton` component inside of the `@fluentui/react-button` package using our latest technology stack and patterns.

#### Focus areas to test

(optional)
@msft-github-bot msft-github-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Sep 9, 2020
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14855, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14855, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

hutchcodes pushed a commit to hutchcodes/fluentui that referenced this issue Sep 10, 2020
@khmakoto @hutchcodes
CompoundButton: Adding initial component to react-button package (mic…
463be51 
…rosoft#14855)

#### Pull request checklist

- [x] Addresses an existing issue: Fixes microsoft#14671
- [x] Include a change request file using `$ yarn change`

#### Description of changes

This PR adds an implementation for the `CompoundButton` component inside of the `@fluentui/react-button` package using our latest technology stack and patterns.

#### Focus areas to test

(optional)
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@khmakoto khmakoto

Labels
Component: Button Status: Fixed Fixed in some PR
Projects
None yet
Milestone
v8: Pre-snap
Development

Successfully merging a pull request may close this issue.

CompoundButton: Adding initial component to react-button package khmakoto/fluentui
4 participants
@ecraig12345 @khmakoto @JustSlone @msft-github-bot