[pull] master from angular:master #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Cleans up a few leftovers that were accidentally missed in: 0f8d529
…#14477) We use a `ContentChild` to determine what lazy content to render inside an expansion panel. When the lazy content is nested further down inside another expansion panel, all ancestor panels up the tree will pick up the lowest lazy content from the lowest level. These changes add a check to ensure that the lazy content is rendered out by the closest panel. Fixes #14365.
#24498) Fixes a null pointer exception that can happen if the page is scrolled before the user has scrolled the minimum distance. The problem was that we were expecting for the dimensions to be defined by the time the user has had the chance to scroll, but in some cases that can be circumvented. These changes move the measurement to a getter method so that they're guaranteed to be available when they are requested. Fixes #24497.
As `addModuleImportToRootModule` is a void function, the test expectations in its result (value undefined) using '.not' would always be true. This change reads the file content and therefore gives the test its sense.
Usually the theme divider color is rgba, which means that it can look differently, depending on the color behind it. As a result, the border of a selected button toggle is different from a deselected one, because its background color is darker. These changes switch to using a solid color to ensure that we have always have a consistent border. These changes also add a new theming utility function that converts an rgba color to hex, if the consumer knows the background. We've been using it in a couple of places already, but now it's being moved out into a reusable function.
… have been specified (#18271) Previously, calling `sendKeys` without any keys resulted in a runtime exception `Cannot read X of undefined` error being thrown. This is because the first element of the passed arguments to `sendKeys` has been considered always truthy. This assumption is wrong since arbitrary amount of arguments can be passed due to the spread parameter. To ensure consistent and reasonable behavior of this function, we fix the runtime exception mentioned above, but throw if no keys have been determined (not necessarily only if the arguments length is zero).
The dev-infra package now bundles dependencies properly and no longer lists them as `dependencies`. This results in our deep imports breaking due to missing dependencies. The solution is the use of the bundled entry-points so that we get all the required transitive dependencies without needing to install them manually.
…en by structural styles (#22736) The button's density styles currently have the same specificity as the structural styles which means that they'll usually be overwritten, unless they're nested inside another selector. These changes add more specificity so that the density always has precedence. Fixes #22728.
…eleaseAction` instance (#24509) Fixes the standalone release checks running outside of the `.ng-dev` config load, which comes with the `global.ReleaseAction`. In standalone checks this variable is not defined and therefore currently causes errors like: ``` /.ng-dev/release.ts:14 const actionProto = (global as any).ReleaseAction.prototype; ^ TypeError: Cannot read properties of undefined (reading 'prototype') at Object.<anonymous> ``` We can fallback to the imported `ReleaseAction` constructor object if the global reference is not provided. In such cases the monkey-patching is a noop anyway.
Co-authored-by: Renovate Bot <[email protected]>
Allows for the text inside a text column to be centered. Fixes #23920.
…24513) Previously the message was not very clear about what happened if reading the warning. The new wording states that a project is skipped during migrations which should be clearer to users.
…22901) Fixes that the button component was always setting a `tabindex="0"` when it's placed on a link element. This is unnecessary, because links are in the tab order by default. We actually had a test that has an assertion against this, but it was passing by accident because we weren't running change detection before making the asserting.
Bumps to Angular 14.0.0-next.5 and Zone.js 0.11.5. The Angular update includes the injector in `createEmbeddedView` feature that we'll need soon and the Zone.js update should remove some deprecation warnings that have been polluting our logs.
Removes the APIs that were marked for removal in version 13 in the `material/list` package. BREAKING CHANGE: * `mat-list-item-avatar` CSS class has been renamed to `mat-list-item-with-avatar`. * `MatSelectionListChange.option` has been removed. Use `MatSelectionListChange.options` instead. * `MatSelectionList.tabIndex` input has been removed. * `tabIndex` parameter of the `MatSelectionList` constructor has been removed. * `_focusMonitor` parameter of the `MatSelectionList` constructor is now required. * `getHarnessLoaderForContent` has been removed from the various test item harnesses. Use `getChildLoader(MatListItemSection.CONTENT)` instead.
#24766) * fix(material-experimental/mdc-slider): remove pointerdown passive event listener options * setting {passive: true} causes the slider foundation to error when it calls event.preventDefault * fixup! fix(material-experimental/mdc-slider): remove pointerdown passive event listener options * fixup! fix(material-experimental/mdc-slider): remove pointerdown passive event listener options * fixup! fix(material-experimental/mdc-slider): remove pointerdown passive event listener options
Adds method `setFreeDragPosition` in Cdk `DragDrop` directive to set position in pixel on a drop container. Also corrects some inaccurate types on a couple of freeDragPosition methods of the `DragDrop` directive. Fixes #18530
* build: update bazel setup and angular This should fix the snapshot CI job * build: update goldens after type signature changes in compiler The signatures changed with: angular/angular@d3c0fa3
…24816) Updates to the latest version of the Sass Bazel rules. We landed a fix upstream, allowing us to provide a vendored Yarn script, instead of needing a separate download of Yarn (with a warning polluting the Bazel output)
…son` (#24697) As part of the Yarn PNP changes we moved from `peerDependencies` in the experimental package to actual `dependencies` on all individual MDC packages we rely on. This is necessary for Yarn PnP and conceptually also makes the package more correct/safe. This resulted in duplication of the MDC dependencies, making MDC updates more complicated. We can avoid duplication by auto-inserting the dependencies. That way we keep two places for the MDC deps: * The project `package.json` * `packages.bzl` for the Bazel analysis phase/Starlark.
Co-authored-by: Renovate Bot <[email protected]>
We have a test that verifies that we're able to read workspaces in JSON5 format. The devkit appears to have switched to `jsonc-parse` for the config file parsing which only supports comments in JSON, not trailing commas and unquoted keys. These changes adjust our test to account for the new parsing behavior.
Some samples have been missing imports, which can confuse some devs. I added them.
When an overlay is detached, we remove it from the change detection tree and the DOM, but we don't destroy it completely so that it can be re-attached. Re-attachment is the same process, but in reverse: we re-add the element to the DOM and the change detection tree. The problem is that we were attaching the element to the change detection tree before re-inserting it into the DOM which caused the Angular animations package not to animate the element since it's not in the DOM yet. These changes resolve the issue by attaching the element to the DOM first. Fixes #24749.
Fixes a bug in Angular Material `autocomplete` when outside click doesn't trigger `changeDetection`. Fixes #24811
…tory (#24823) Updates the Github actions now that angular/dev-infra@c9d0bf5 has landed.
Moves the code for the CDK experimental menu into the CDK.
DEPRECATED: `mat.define-dark-theme` no longer accepts `$primary`, `$accent` and `$warn`. Pass a single config map instead. DEPRECATED: `mat.define-light-theme` no longer accepts `$primary`, `$accent` and `$warn`. Pass a single config map instead. DEPRECATED: Custom Material themes should no longer access `primary`, `accent`, `warn`, `is-dark`, `foreground` and `background` from the theme map, but instead use the actual `color` configuration (`mat.get-color-config($theme)`). DEPRECATED: Passing a color configuration directly to a `-theme` mixin is not supported. Pass the theme container object instead or use the dedicated `-color` mixins.
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25
Disables the feature request triage bot.
Adjusts the public API of the CDK dialog based on a recent feedback session by: * Expanding `DialogRef.restoreFocus` to allow CSS selectors and DOM nodes. * Changing `Dialog.openDialogs`, `DialogRef.componentInstance` and `DialogRef.containerInstance` to be readonly. * Allowing for numbers to be passed in to `DialogRef.updateSize`. * Updating the doc string of `DialogRef.updateSize`.
…erimental` package json (#24846) We recently started auto-generating the material-experimental package.json file to avoid duplicating the MDC version/deps across multiple places. The staging checks assume a `package.json` file to be visible in the source files. For our checks it is sufficient to use the handwritten base package.json file.
The `typography-hierarchy` mixin was missing from the documentation. This adds a couple of sentences mentioning that it exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )