-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessibility table examples #23821
Fix accessibility table examples #23821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Just one thing to change and we can get these changes in.
@andrewseguin Maybe I missed the suggested change, but I can't see the thing to change? |
Odd my comment didn't get through, maybe because it's not an affected line. Be sure to change |
I added the fix. Maybe one question from me: I saw there is an experimental section too for table. Should I apply the fix there too in this PR? |
35480f5
to
21c1079
Compare
Yes - that'd be great if you can add the fix to the MDC based versions. We're working on making those the primary versions now |
7446dc9
to
1a49cf5
Compare
1a49cf5
to
21c1079
Compare
…/forsti0506/components into fix-accessibility-table-examples
@andrewseguin I added the features for the mdc examples. I'm not sure how to fix the CircleCi errors, because the build fails because of my master merge! |
…x example accessibility
It looks like one of the issues is that |
Yes thanks: closing tag is fixed, but I think the merge is blocked, because of the commit message for the master merge! |
…y complex flex example
16bb33e
to
9339019
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Hello,
I'd like to commit some fixes to the accessibility of the angular examples. In my opinion many people are copying these examples and therefore it is important to provide accessible examples.
First I added an arrow to expand tables, because otherwise the row is only accessible by clicking with a mouse!
I hope you have time to review my first Pull request!
The `nbsp; is needed, because for example NVDA doesn't recognize it, if it is used without any content!
Second Part is to enable focusing scrollable regions to ensure that screen an tabusers can access them!
Thanks in Advance!
Best regards,
Martin