Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cdk/clipboard): Add imports to samples #21910

Merged
merged 1 commit into from
Apr 22, 2022
Merged

docs(cdk/clipboard): Add imports to samples #21910

merged 1 commit into from
Apr 22, 2022

Conversation

kirjs
Copy link
Contributor

@kirjs kirjs commented Feb 15, 2021

Standalone Clipboard samples have been missing imports, which can confuse some devs.
I added them.

@kirjs kirjs requested a review from jelbourn as a code owner February 15, 2021 17:16
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 15, 2021
crisbeto
crisbeto reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but the CI is failing, because the commit title is incorrect. It should be docs(cdk/clipboard) instead of docs(material/clipboard).

@kirjs kirjs changed the title docs(material/clipboard): Add imports to samples docs(cdk/clipboard): Add imports to samples Feb 26, 2021
@kirjs
Copy link
Contributor Author

kirjs commented Feb 26, 2021

PTAL

@kirjs
docs(cdk/clipboard): add imports to samples
4c19ae0 
Some samples have been missing imports, which can confuse some devs.
I added them.
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Apr 22, 2022
@andrewseguin andrewseguin merged commit 54cb83e into angular:master Apr 22, 2022
andrewseguin pushed a commit that referenced this pull request Apr 22, 2022
@kirjs @andrewseguin
docs(cdk/clipboard): add imports to samples (#21910)
fc6fcbb 
Some samples have been missing imports, which can confuse some devs.
I added them.

(cherry picked from commit 54cb83e)
This was referenced Apr 28, 2022
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@andrewseguin andrewseguin andrewseguin approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirjs @crisbeto @andrewseguin