build: fix test failure with latest CLI version #24820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a test that verifies that we're able to read workspaces in JSON5 format. The devkit appears to have switched to `jsonc-parse` for the config file parsing which only supports comments in JSON, not trailing commas and unquoted keys. These changes adjust our test to account for the new parsing behavior.
crisbeto
added
P3
crisbeto
requested review from
a team,
devversion and
andrewseguin
as code owners
devversion
approved these changes
Apr 22, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test that verifies that we're able to read workspaces in JSON5 format. The devkit appears to have switched to
jsonc-parsefor the config file parsing which only supports comments in JSON, not trailing commas and unquoted keys. These changes adjust our test to account for the new parsing behavior.