Update Bazel code to account for rules_nodejs v5 change
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rules_nodejs` v5 package moved the `ts_library`, `ts_project` rules from `@bazel/typescript` to `@bazel/concatjs`. The majority of users is not using `ts_library` but rather a simpler, less-optimal rule called `ts_project` (hence the move from `@bazel/typescript` into the rather-legacy concatjs package -- which originates from the old g3 export)
devversion
added a commit
to gkalpak/angular
that referenced
this pull request
Mar 22, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
devversion
added a commit
to gkalpak/angular
that referenced
this pull request
Mar 22, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
devversion
added a commit
to gkalpak/angular
that referenced
this pull request
Mar 23, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
devversion
added a commit
to devversion/angular
that referenced
this pull request
Mar 24, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
devversion
added a commit
to devversion/angular
that referenced
this pull request
Mar 24, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
devversion
added a commit
to devversion/angular
that referenced
this pull request
Mar 25, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
|
Hi @devversion, thanks for the report! Due to our internal setup, we can't import code from GitHub to our internal code base. I will work on this within Google and address the issue, and then release the patch to GitHub. |
dylhunn
pushed a commit
to angular/angular
that referenced
this pull request
Mar 25, 2022
…js` v5 (#45431) Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released. PR Close #45431
devversion
added a commit
to devversion/angular
that referenced
this pull request
Mar 25, 2022
…js` v5 Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released.
dylhunn
pushed a commit
to angular/angular
that referenced
this pull request
Mar 25, 2022
…js` v5 (#45443) Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released. PR Close #45443
PiyushAgrawal1243
pushed a commit
to PiyushAgrawal1243/angular
that referenced
this pull request
Mar 30, 2022
…js` v5 (angular#45431) Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until google/tsec#25 is available/released. PR Close angular#45431
|
@devversion 0.2.2 is released. It should fix the problem. |
devversion
added a commit
to devversion/angular
that referenced
this pull request
Apr 26, 2022
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 26, 2022
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 26, 2022
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25
andrewseguin
pushed a commit
to angular/components
that referenced
this pull request
Apr 26, 2022
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25
andrewseguin
pushed a commit
to angular/components
that referenced
this pull request
Apr 26, 2022
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25 (cherry picked from commit 3b43c7b)
atscott
pushed a commit
to angular/angular
that referenced
this pull request
Apr 26, 2022
Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: google/tsec#25 PR Close #45767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rules_nodejsv5 package moved thets_library,ts_projectrules from@bazel/typescriptto@bazel/concatjs.The majority of users is not using
ts_librarybut rather a simpler, less-optimal rule calledts_project(hence themove from
@bazel/typescriptinto the rather-legacy concatjs package -- which originates from the old g3 export)Related angular/angular#45235
@uraj could you potentially help with landing and releasing this to unblock Angular? thanks!