refactor(material/sort): explicit sort direction #23632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Sep 25, 2021
lekhmanrus
force-pushed
the
explicit-sort-direction-type
branch
from
924a148 to
cb472c8
Compare
|
Is there a way to restart ci/circleci: tests_browserstack test? |
|
@lekhmanrus I have triggered a rerun of the failing test. |
lekhmanrus
force-pushed
the
explicit-sort-direction-type
branch
from
cb472c8 to
e54f1fc
Compare
|
Looks like the failing test is unrelated to the change. Could we rerun it again, please? |
andrewseguin
removed
the
cla: yes
lekhmanrus
force-pushed
the
explicit-sort-direction-type
branch
from
e54f1fc to
18aa02e
Compare
andrewseguin
added
the
target: patch
andrewseguin
approved these changes
Apr 21, 2022
|
I can't remember if we wanted these to explicitly NOT be the empty string, but I can't think of a good enough justification now for it |
andrewseguin
pushed a commit
that referenced
this pull request
Apr 22, 2022
(cherry picked from commit 37db2d5)
This was referenced Apr 28, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if that is really needed.
Just it feels like it is more consistent with existing
SortDirection. 🙂