build: avoid duplication of mdc dependencies by generating package.json
#24697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
approved these changes
Apr 21, 2022
|
Is this ready to go? CI failed on the |
…son` As part of the Yarn PNP changes we moved from `peerDependencies` in the experimental package to actual `dependencies` on all individual MDC packages we rely on. This is necessary for Yarn PnP and conceptually also makes the package more correct/safe. This resulted in duplication of the MDC dependencies, making MDC updates more complicated. We can avoid duplication by auto-inserting the dependencies. That way we keep two places for the MDC deps: * The project `package.json` * `packages.bzl` for the Bazel analysis phase/Starlark.
devversion
force-pushed
the
avoid-duplication-mdc-deps
branch
from
23d153f to
ad630bd
Compare
|
@andrewseguin yeah, this should be ready now. This was also blocked on the FW release (since previously the package.json could not be auto-generated -- I added this feature) |
devversion
added
merge safe
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Yarn PNP changes we moved from
peerDependenciesin theexperimental package to actual
dependencieson all individual MDCpackages we rely on. This is necessary for Yarn PnP and conceptually
also makes the package more correct/safe.
This resulted in duplication of the MDC dependencies, making MDC
updates more complicated. We can avoid duplication by auto-inserting
the dependencies. That way we keep two places for the MDC deps:
package.jsonpackages.bzlfor the Bazel analysis phase/Starlark.