Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix github actions breaking due to symlink in dev-infra repository #24823

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

devversion
Copy link
Member

Updates the Github actions now that angular/dev-infra@c9d0bf5 has landed.

@devversion devversion requested a review from a team as a code owner April 22, 2022 18:46
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels Apr 22, 2022
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Apr 22, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel
Copy link
Contributor

@devversion @josephperrott
Is this ok to merge in despite the failing CI?

@devversion
Copy link
Member Author

yes, the failing job is based on master and doesn't benefit from this fix yet

@wagnermaciel wagnermaciel merged commit c03fd6e into angular:master Apr 22, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants